no more setup.py called explicitly

Author: vmoens

.github/workflows/nightly_build.yml

@@ -66,10 +66,9 @@ jobs:
         run: |
           rm -r dist || true
           export PATH="/opt/python/${{ matrix.python_version[1] }}/bin:$PATH"
-          python3 -mpip install wheel
-          python3 setup.py bdist_wheel \
-            --python-tag=${{ matrix.python-tag }}
-           find dist -name '*whl' -exec bash -c ' mv $0 ${0/linux/manylinux1}' {} \;
+          python3 -mpip install build
+          python3 -m build --wheel
+          find dist -name '*whl' -exec bash -c ' mv $0 ${0/linux/manylinux1}' {} \;
       # pytorch/pytorch binaries are also manylinux_2_17 compliant but they
       # pretend that they're manylinux1 compliant so we do the same.
       - name: Upload wheel for the test-wheel job
@@ -229,9 +228,8 @@ jobs:
         shell: bash
         run: |
           rm -r dist || true
-          python3 -mpip install wheel
-          python3 setup.py bdist_wheel \
-            --python-tag=${{ matrix.python-tag }}
+          python3 -mpip install build
+          python3 -m build --wheel
       - name: Upload wheel for the test-wheel job
         uses: actions/upload-artifact@v4
         with:

MANIFEST.in

@@ -1 +1 @@
-include torchrl/version.py 
+include torchrl/version.py 

README.md

@@ -972,7 +972,8 @@ such as `apt`, `apt-get`, `conda` or `yum` but NOT `pip`, as well as `pip instal
 
 One can also build the wheels to distribute to co-workers using
 ```bash
-python setup.py bdist_wheel
+pip install build
+python -m build --wheel
 ```
 Your wheels will be stored there `./dist/torchrl<name>.whl` and installable via
 ```bash

packaging/build_wheels.sh

@@ -7,10 +7,9 @@ script_dir="$( cd "$( dirname "${BASH_SOURCE[0]}" )" >/dev/null 2>&1 && pwd )"
 export BUILD_TYPE=wheel
 setup_env
 setup_wheel_python
-pip_install numpy pyyaml future ninja
+pip_install numpy pyyaml future ninja build
 pip_install --upgrade setuptools
 setup_pip_pytorch_version
-python setup.py clean
 
 # Copy binaries to be included in the wheel distribution
 if [[ "$(uname)" == Darwin || "$OSTYPE" == "msys" ]]; then
@@ -29,9 +28,9 @@ else
 fi
 
 if [[ "$OSTYPE" == "msys" ]]; then
-    IS_WHEEL=1 "$script_dir/windows/internal/vc_env_helper.bat" python setup.py bdist_wheel
+    IS_WHEEL=1 "$script_dir/windows/internal/vc_env_helper.bat" python -m build --wheel
 else
-    python setup.py bdist_wheel
+    python -m build --wheel
     if [[ "$(uname)" != Darwin ]]; then
       rename "linux_x86_64" "manylinux1_x86_64" dist/*.whl
     fi

setup.py

@@ -45,8 +45,8 @@ def write_version_file(version):
         f.write(f"__version__ = '{version}'\n")
         f.write(f"git_version = {repr(sha)}\n")
         f.write(f"pytorch_version = '{pytorch_version}'\n")
-    
-    logging.info(f"Version file written successfully")
+
+    logging.info("Version file written successfully")
 
 
 class clean(Command):
@@ -151,7 +151,12 @@ def _main():
         # For regular builds, append git hash for development versions
         try:
             import subprocess
-            git_sha = subprocess.check_output(["git", "rev-parse", "HEAD"], cwd=cwd).decode("ascii").strip()[:7]
+
+            git_sha = (
+                subprocess.check_output(["git", "rev-parse", "HEAD"], cwd=cwd)
+                .decode("ascii")
+                .strip()[:7]
+            )
             version = f"{base_version}+{git_sha}"
             logging.info(f"Using development version: {version}")
         except Exception:
@@ -161,15 +166,17 @@ def _main():
     # Always write the version file to ensure it's up to date
     write_version_file(version)
     logging.info(f"Building torchrl-{version}")
-    
+
     # Verify the version file was written correctly
     try:
-        with open(os.path.join(cwd, "torchrl", "version.py"), "r") as f:
+        with open(os.path.join(cwd, "torchrl", "version.py")) as f:
             content = f.read()
             if f"__version__ = '{version}'" in content:
                 logging.info(f"Version file correctly contains: {version}")
             else:
-                logging.error(f"Version file does not contain expected version: {version}")
+                logging.error(
+                    f"Version file does not contain expected version: {version}"
+                )
     except Exception as e:
         logging.error(f"Failed to verify version file: {e}")
 
@@ -178,7 +185,7 @@ def _main():
         package_name = "torchrl-nightly"  # Use torchrl-nightly for PyPI uploads
     else:
         package_name = "torchrl"  # Use torchrl for regular builds and GitHub discovery
-    
+
     setup_kwargs = {
         "name": package_name,
         # Only C++ extension configuration
@@ -193,7 +200,7 @@ def _main():
         },
         "include_package_data": True,
     }
-    
+
     # Handle nightly tensordict dependency override
     if is_nightly:
         setup_kwargs["install_requires"] = [
@@ -207,25 +214,29 @@ def _main():
     # Override pyproject.toml settings for nightly builds
     if is_nightly:
         # Add all the metadata from pyproject.toml but override the name
-        setup_kwargs.update({
-            "description": "A modular, primitive-first, python-first PyTorch library for Reinforcement Learning",
-            "long_description": (Path(__file__).parent / "README.md").read_text(encoding="utf8"),
-            "long_description_content_type": "text/markdown",
-            "author": "torchrl contributors",
-            "author_email": "vmoens@fb.com",
-            "url": "https://github.com/pytorch/rl",
-            "classifiers": [
-                "Programming Language :: Python :: 3.9",
-                "Programming Language :: Python :: 3.10",
-                "Programming Language :: Python :: 3.11",
-                "Programming Language :: Python :: 3.12",
-                "Operating System :: OS Independent",
-                "Development Status :: 4 - Beta",
-                "Intended Audience :: Developers",
-                "Intended Audience :: Science/Research",
-                "Topic :: Scientific/Engineering :: Artificial Intelligence",
-            ],
-        })
+        setup_kwargs.update(
+            {
+                "description": "A modular, primitive-first, python-first PyTorch library for Reinforcement Learning",
+                "long_description": (Path(__file__).parent / "README.md").read_text(
+                    encoding="utf8"
+                ),
+                "long_description_content_type": "text/markdown",
+                "author": "torchrl contributors",
+                "author_email": "vmoens@fb.com",
+                "url": "https://github.com/pytorch/rl",
+                "classifiers": [
+                    "Programming Language :: Python :: 3.9",
+                    "Programming Language :: Python :: 3.10",
+                    "Programming Language :: Python :: 3.11",
+                    "Programming Language :: Python :: 3.12",
+                    "Operating System :: OS Independent",
+                    "Development Status :: 4 - Beta",
+                    "Intended Audience :: Developers",
+                    "Intended Audience :: Science/Research",
+                    "Topic :: Scientific/Engineering :: Artificial Intelligence",
+                ],
+            }
+        )
 
     setup(**setup_kwargs)
 

torchrl/__init__.py

@@ -29,13 +29,20 @@
     try:
         import os
         import subprocess
+
         version_file = os.path.join(os.path.dirname(__file__), "..", "version.txt")
-        with open(version_file, "r") as f:
+        with open(version_file) as f:
             base_version = f.read().strip()
-        
+
         # Try to get git hash
         try:
-            git_sha = subprocess.check_output(["git", "rev-parse", "HEAD"], cwd=os.path.dirname(version_file)).decode("ascii").strip()[:7]
+            git_sha = (
+                subprocess.check_output(
+                    ["git", "rev-parse", "HEAD"], cwd=os.path.dirname(version_file)
+                )
+                .decode("ascii")
+                .strip()[:7]
+            )
             __version__ = f"{base_version}+{git_sha}"
         except Exception:
             __version__ = base_version