[CI] Fix old deps

ghstack-source-id: 109de71
Pull Request resolved: #2916

Author: Vincent Moens

.github/unittest/linux_libs/scripts_envpool/setup_env.sh

@@ -81,15 +81,7 @@ if [[ $OSTYPE != 'darwin'* ]]; then
   # rename them
   PY_VERSION=$(python --version)
   echo "installing ale-py for ${PY_PY_VERSION}"
-  if [[ $PY_VERSION == *"3.7"* ]]; then
-    wget https://files.pythonhosted.org/packages/ab/fd/6615982d9460df7f476cad265af1378057eee9daaa8e0026de4cedbaffbd/ale_py-0.8.0-cp37-cp37m-manylinux_2_17_x86_64.manylinux2014_x86_64.whl
-    pip install ale_py-0.8.0-cp37-cp37m-manylinux_2_17_x86_64.manylinux2014_x86_64.whl
-    rm ale_py-0.8.0-cp37-cp37m-manylinux_2_17_x86_64.manylinux2014_x86_64.whl
-  elif [[ $PY_VERSION == *"3.8"* ]]; then
-    wget https://files.pythonhosted.org/packages/0f/8a/feed20571a697588bc4bfef05d6a487429c84f31406a52f8af295a0346a2/ale_py-0.8.0-cp38-cp38-manylinux_2_17_x86_64.manylinux2014_x86_64.whl
-    pip install ale_py-0.8.0-cp38-cp38-manylinux_2_17_x86_64.manylinux2014_x86_64.whl
-    rm ale_py-0.8.0-cp38-cp38-manylinux_2_17_x86_64.manylinux2014_x86_64.whl
-  elif [[ $PY_VERSION == *"3.9"* ]]; then
+  if [[ $PY_VERSION == *"3.9"* ]]; then
     wget https://files.pythonhosted.org/packages/a0/98/4316c1cedd9934f9a91b6e27a9be126043b4445594b40cfa391c8de2e5e8/ale_py-0.8.0-cp39-cp39-manylinux_2_17_x86_64.manylinux2014_x86_64.whl
     pip install ale_py-0.8.0-cp39-cp39-manylinux_2_17_x86_64.manylinux2014_x86_64.whl
     rm ale_py-0.8.0-cp39-cp39-manylinux_2_17_x86_64.manylinux2014_x86_64.whl

.github/unittest/linux_olddeps/scripts_gym_0_13/install.sh

@@ -37,24 +37,25 @@ git submodule sync && git submodule update --init --recursive
 
 printf "Installing PyTorch with %s\n" "${CU_VERSION}"
 if [ "${CU_VERSION:-}" == cpu ] ; then
-    conda install pytorch==2.0 torchvision==0.15 cpuonly -c pytorch -y
+    conda install pytorch==2.1 torchvision==0.16 cpuonly -c pytorch -y
 else
-    conda install pytorch==2.0.1 torchvision==0.15.2 torchaudio==2.0.2 pytorch-cuda=11.8 "numpy<2.0" -c pytorch -c nvidia -y
+    pip install torch==2.1.1 torchvision==0.16.1 torchaudio==2.1.1 --index-url https://download.pytorch.org/whl/cu118
+#    conda install pytorch==2.1 torchvision==0.16 pytorch-cuda=11.8 "numpy<2.0" -c pytorch -c nvidia -y
 fi
 
 # Solving circular import: https://stackoverflow.com/questions/75501048/how-to-fix-attributeerror-partially-initialized-module-charset-normalizer-has
-pip install -U charset-normalizer
+#pip install -U charset-normalizer
 
 # install tensordict
 if [[ "$RELEASE" == 0 ]]; then
-  pip3 install git+https://github.com/pytorch/tensordict.git
+  python3 -m pip install git+https://github.com/pytorch/tensordict.git
 else
-  pip3 install tensordict
+  python3 -m pip install tensordict
 fi
 
 # smoke test
-python -c "import tensordict"
+python3 -c "import tensordict"
 
 printf "* Installing torchrl\n"
-python setup.py develop
-python -c "import torchrl"
+python3 setup.py develop
+python3 -c "import torchrl"

.github/workflows/test-linux.yml

@@ -94,18 +94,18 @@ jobs:
   tests-olddeps:
     strategy:
       matrix:
-        python_version: ["3.8"]
+        python_version: ["3.9"]
         cuda_arch_version: ["11.6"]
     uses: pytorch/test-infra/.github/workflows/linux_job_v2.yml@main
     with:
       repository: pytorch/rl
       runner: "linux.g5.4xlarge.nvidia.gpu"
-      docker-image: "nvidia/cudagl:11.4.0-base"
+      docker-image: "nvidia/cuda:11.8.0-cudnn8-devel-ubuntu20.04"
       timeout: 120
       script: |
         set -euo pipefail
-        export PYTHON_VERSION="3.8"
-        export CU_VERSION="cu116"
+        export PYTHON_VERSION="3.9"
+        export CU_VERSION="cu118"
         export TAR_OPTIONS="--no-same-owner"
         if [[ "${{ github.ref }}" =~ release/* ]]; then
           export RELEASE=1

test/test_loggers.py

@@ -14,6 +14,7 @@
 
 import pytest
 import torch
+from packaging import version
 from tensordict import MemoryMappedTensor
 
 from torchrl.envs import check_env_specs, GymEnv, ParallelEnv
@@ -26,6 +27,12 @@
 if _has_tv:
     import torchvision
 
+    TORCHVISION_VERSION = version.parse(
+        version.parse(torchvision.__version__).base_version
+    )
+else:
+    TORCHVISION_VERSION = version.parse("0.0.1").base_version
+
 if _has_tb:
     from tensorboard.backend.event_processing.event_accumulator import EventAccumulator
 
@@ -164,6 +171,9 @@ def test_log_scalar(self, steps, tmpdir):
     @pytest.mark.parametrize(
         "video_format", ["pt", "memmap"] + ["mp4"] if _has_tv else []
     )
+    @pytest.mark.skipif(
+        TORCHVISION_VERSION < version.parse("0.20.0"), reason="av compatibility bug"
+    )
     def test_log_video(self, steps, video_format, tmpdir):
         torch.manual_seed(0)
         exp_name = "ramala"

test/test_rb.py

@@ -1119,6 +1119,9 @@ def test_storage_inplace_writing_ndim(self, storage_type):
         assert (rb[:, 10:20] == 0).all()
         assert len(rb) == 100
 
+    @pytest.mark.skipif(
+        TORCH_VERSION < version.parse("2.5.0"), reason="requires Torch >= 2.5.0"
+    )
     @pytest.mark.parametrize("max_size", [1000, None])
     @pytest.mark.parametrize("stack_dim", [-1, 0])
     def test_lazy_stack_storage(self, max_size, stack_dim):

test/test_storage_map.py

@@ -7,6 +7,7 @@
 import argparse
 import functools
 import importlib.util
+import os
 
 import pytest
 
@@ -23,6 +24,11 @@
 )
 from torchrl.envs import GymEnv
 
+if os.getenv("PYTORCH_TEST_FBCODE"):
+    from pytorch.rl.test._utils_internal import PENDULUM_VERSIONED
+else:
+    from _utils_internal import PENDULUM_VERSIONED
+
 _has_gym = importlib.util.find_spec("gymnasium", None) or importlib.util.find_spec(
     "gym", None
 )
@@ -603,7 +609,7 @@ def test_forest_intersect_vertices(self):
     def test_simple_tree(self):
         from torchrl.envs import GymEnv
 
-        env = GymEnv("Pendulum-v1")
+        env = GymEnv(PENDULUM_VERSIONED())
         r = env.rollout(10)
         state0 = r[0]
         forest = MCTSForest()
@@ -630,7 +636,7 @@ def test_forest_parent(self, tree_type, compact):
                 pytest.skip("requires gym")
             from torchrl.envs import GymEnv
 
-            env = GymEnv("Pendulum-v1")
+            env = GymEnv(PENDULUM_VERSIONED())
             r = env.rollout(10)
             state0 = r[0]
             forest = MCTSForest()

test/test_transforms.py

@@ -766,15 +766,15 @@ def get_rand_perm(ndim):
     @pytest.mark.parametrize("cat_dim", [-1, -2])
     def test_with_permute_env(self, cat_dim):
         env0 = TransformedEnv(
-            GymEnv("Pendulum-v1"),
+            GymEnv(PENDULUM_VERSIONED()),
             Compose(
                 UnsqueezeTransform(-1, in_keys=["observation"]),
                 CatFrames(N=4, dim=cat_dim, in_keys=["observation"]),
             ),
         )
 
         env1 = TransformedEnv(
-            GymEnv("Pendulum-v1"),
+            GymEnv(PENDULUM_VERSIONED()),
             Compose(
                 UnsqueezeTransform(-1, in_keys=["observation"]),
                 PermuteTransform((-1, -2), in_keys=["observation"]),
@@ -9566,7 +9566,7 @@ def test_vecnorm2_decay1(self, batched):
     @pytest.mark.parametrize("stateful", [True, False])
     def test_stateful_and_stateless_specs(self, stateful):
         torch.manual_seed(0)
-        env = GymEnv("Pendulum-v1")
+        env = GymEnv(PENDULUM_VERSIONED())
         env.set_seed(0)
         env = env.append_transform(
             VecNorm(
@@ -9588,7 +9588,7 @@ def test_stateful_vs_stateless(self):
         counts = []
         for stateful in [True, False]:
             torch.manual_seed(0)
-            env = GymEnv("Pendulum-v1")
+            env = GymEnv(PENDULUM_VERSIONED())
             env.set_seed(0)
             env = env.append_transform(
                 VecNorm(