[CI, BugFix] Fix gym related errors (#895)

Author: vmoens

.circleci/unittest/linux/scripts/environment.yml

@@ -18,6 +18,7 @@ dependencies:
     - pytest-cov
     - pytest-mock
     - pytest-instafail
+    - pytest-rerunfailures
     - expecttest
     - pyyaml
     - scipy

.circleci/unittest/linux/scripts/run_test.sh

@@ -1,11 +1,5 @@
 #!/usr/bin/env bash
 
-# this code is supposed to run on CPU
-# rendering with the combination of packages we have here in headless mode
-# is hard to nail.
-# IMPORTANT: As a consequence, we can't guarantee TorchRL compatibility with
-# rendering with this version of gym / mujoco-py.
-
 set -e
 
 eval "$(./conda/bin/conda shell.bash hook)"
@@ -23,6 +17,7 @@ lib_dir="${env_dir}/lib"
 # solves ImportError: /lib64/libstdc++.so.6: version `GLIBCXX_3.4.21' not found
 export LD_LIBRARY_PATH=$LD_LIBRARY_PATH:$lib_dir
 export MKL_THREADING_LAYER=GNU
+export CKPT_BACKEND=torch
 
 python .circleci/unittest/helpers/coverage_run_parallel.py -m pytest test/smoke_test.py -v --durations 20
 python .circleci/unittest/helpers/coverage_run_parallel.py -m pytest test/smoke_test_deps.py -v --durations 20 -k 'test_gym or test_dm_control_pixels or test_dm_control or test_tb'

.circleci/unittest/linux/scripts/setup_env.sh

@@ -38,15 +38,15 @@ if [ ! -d "${env_dir}" ]; then
 fi
 conda activate "${env_dir}"
 
-# 3. Install mujoco
-printf "* Installing mujoco and related\n"
-mkdir -p $root_dir/.mujoco
-cd $root_dir/.mujoco/
-wget https://github.com/deepmind/mujoco/releases/download/2.1.1/mujoco-2.1.1-linux-x86_64.tar.gz
-tar -xf mujoco-2.1.1-linux-x86_64.tar.gz
-wget https://mujoco.org/download/mujoco210-linux-x86_64.tar.gz
-tar -xf mujoco210-linux-x86_64.tar.gz
-cd $this_dir
+## 3. Install mujoco
+#printf "* Installing mujoco and related\n"
+#mkdir -p $root_dir/.mujoco
+#cd $root_dir/.mujoco/
+#wget https://github.com/deepmind/mujoco/releases/download/2.1.1/mujoco-2.1.1-linux-x86_64.tar.gz
+#tar -xf mujoco-2.1.1-linux-x86_64.tar.gz
+#wget https://mujoco.org/download/mujoco210-linux-x86_64.tar.gz
+#tar -xf mujoco210-linux-x86_64.tar.gz
+#cd $this_dir
 
 # 4. Install Conda dependencies
 printf "* Installing dependencies (except PyTorch)\n"
@@ -63,21 +63,13 @@ else
 fi
 
 export MUJOCO_GL=$PRIVATE_MUJOCO_GL
-if [ "${CU_VERSION:-}" == cpu ]; then
-  conda env config vars set MUJOCO_PY_MUJOCO_PATH=$root_dir/.mujoco/mujoco210 \
+conda env config vars set MUJOCO_PY_MUJOCO_PATH=$root_dir/.mujoco/mujoco210 \
   DISPLAY=unix:0.0 \
   MJLIB_PATH=$root_dir/.mujoco/mujoco-2.1.1/lib/libmujoco.so.2.1.1 \
   LD_LIBRARY_PATH=$LD_LIBRARY_PATH:$root_dir/.mujoco/mujoco210/bin \
   SDL_VIDEODRIVER=dummy \
   MUJOCO_GL=$PRIVATE_MUJOCO_GL \
   PYOPENGL_PLATFORM=$PRIVATE_MUJOCO_GL
-else
-  conda env config vars set MUJOCO_PY_MUJOCO_PATH=$root_dir/.mujoco/mujoco210 \
-    MJLIB_PATH=$root_dir/.mujoco/mujoco-2.1.1/lib/libmujoco.so.2.1.1 \
-    LD_LIBRARY_PATH=$LD_LIBRARY_PATH:$root_dir/.mujoco/mujoco210/bin \
-    MUJOCO_GL=$PRIVATE_MUJOCO_GL \
-    PYOPENGL_PLATFORM=$PRIVATE_MUJOCO_GL
-fi
 
 # Software rendering requires GLX and OSMesa.
 if [ $PRIVATE_MUJOCO_GL == 'egl' ] || [ $PRIVATE_MUJOCO_GL == 'osmesa' ] ; then

.circleci/unittest/linux_examples/scripts/environment.yml

@@ -18,6 +18,7 @@ dependencies:
     - pytest-cov
     - pytest-mock
     - pytest-instafail
+    - pytest-rerunfailures
     - expecttest
     - pyyaml
     - scipy

.circleci/unittest/linux_libs/scripts_brax/environment.yml

@@ -11,6 +11,7 @@ dependencies:
     - pytest-cov
     - pytest-mock
     - pytest-instafail
+    - pytest-rerunfailures
     - expecttest
     - pyyaml
     - scipy

.circleci/unittest/linux_libs/scripts_envpool/environment.yml

@@ -16,6 +16,7 @@ dependencies:
     - pytest-cov
     - pytest-mock
     - pytest-instafail
+    - pytest-rerunfailures
     - expecttest
     - pyyaml
     - scipy

.circleci/unittest/linux_libs/scripts_gym/batch_scripts.sh

@@ -14,8 +14,8 @@ conda activate ./env
 $DIR/install.sh
 
 # Extracted from run_test.sh to run once.
-#yum makecache && yum install libglvnd-devel mesa-libGL mesa-libGL-devel mesa-libEGL mesa-libEGL-devel glfw mesa-libOSMesa-devel glew glew-devel egl-utils freeglut xorg-x11-server-Xvfb -y
-yum makecache && yum install libglvnd-devel glew xorg-x11-server-Xvfb zlib-devel egl-utils mesa-libEGL -y
+yum makecache && yum install libglvnd-devel zlib-devel mesa-libGL mesa-libGL-devel mesa-libEGL mesa-libEGL-devel glfw mesa-libOSMesa-devel glew glew-devel egl-utils freeglut xorg-x11-server-Xvfb -y
+#yum makecache && yum install libglvnd-devel glew xorg-x11-server-Xvfb zlib-devel egl-utils freeglut mesa-libEGL -y
 
 
 # This version is installed initially (see environment.yml)
@@ -24,14 +24,15 @@ do
   # Create a copy of the conda env and work with this
   conda deactivate
   conda create --prefix ./cloned_env --clone ./env -y
+  conda activate ./cloned_env
 
   echo "Testing gym version: ${GYM_VERSION}"
   pip3 install 'gym[atari]'==$GYM_VERSION
   $DIR/run_test.sh
 
   # delete the conda copy
   conda deactivate
-  conda env remove -n ./cloned_env
+  conda env remove --prefix ./cloned_env
 done
 
 # gym[atari]==0.19 is broken, so we install only gym without dependencies.
@@ -40,14 +41,15 @@ do
   # Create a copy of the conda env and work with this
   conda deactivate
   conda create --prefix ./cloned_env --clone ./env -y
+  conda activate ./cloned_env
 
   echo "Testing gym version: ${GYM_VERSION}"
   pip3 install gym==$GYM_VERSION
   $DIR/run_test.sh
 
   # delete the conda copy
   conda deactivate
-  conda env remove -n ./cloned_env
+  conda env remove --prefix ./cloned_env
 done
 
 # gym[atari]==0.20 installs ale-py==0.8, but this version is not compatible with gym<0.26, so we downgrade it.
@@ -56,6 +58,7 @@ do
   # Create a copy of the conda env and work with this
   conda deactivate
   conda create --prefix ./cloned_env --clone ./env -y
+  conda activate ./cloned_env
 
   echo "Testing gym version: ${GYM_VERSION}"
   pip3 install 'gym[atari]'==$GYM_VERSION
@@ -64,22 +67,23 @@ do
 
   # delete the conda copy
   conda deactivate
-  conda env remove -n ./cloned_env
+  conda env remove --prefix ./cloned_env
 done
 
 for GYM_VERSION in '0.25'
 do
   # Create a copy of the conda env and work with this
   conda deactivate
   conda create --prefix ./cloned_env --clone ./env -y
+  conda activate ./cloned_env
 
   echo "Testing gym version: ${GYM_VERSION}"
   pip3 install 'gym[atari]'==$GYM_VERSION
   $DIR/run_test.sh
 
   # delete the conda copy
   conda deactivate
-  conda env remove -n ./cloned_env
+  conda env remove --prefix ./cloned_env
 done
 
 # For this version "gym[accept-rom-license]" is required.
@@ -88,6 +92,7 @@ do
   # Create a copy of the conda env and work with this
   conda deactivate
   conda create --prefix ./cloned_env --clone ./env -y
+  conda activate ./cloned_env
 
   echo "Testing gym version: ${GYM_VERSION}"
   pip3 install 'gym[accept-rom-license]'==$GYM_VERSION
@@ -96,5 +101,5 @@ do
 
   # delete the conda copy
   conda deactivate
-  conda env remove -n ./cloned_env
+  conda env remove --prefix ./cloned_env
 done

.circleci/unittest/linux_libs/scripts_gym/environment.yml

@@ -17,6 +17,7 @@ dependencies:
     - pytest-cov
     - pytest-mock
     - pytest-instafail
+    - pytest-rerunfailures
     - expecttest
     - pyyaml
     - scipy

.circleci/unittest/linux_libs/scripts_gym/run_test.sh

@@ -11,6 +11,7 @@ dependencies:
     - pytest-cov
     - pytest-mock
     - pytest-instafail
+    - pytest-rerunfailures
     - expecttest
     - pyyaml
     - scipy