From 5c51a7c760465dc256f00a7758edf937942cdfcb Mon Sep 17 00:00:00 2001 From: Huy Do Date: Thu, 17 Jul 2025 00:48:14 -0700 Subject: [PATCH 1/3] Fix wrong branch name when uploading PR results Signed-off-by: Huy Do --- .github/workflows/vllm-benchmark.yml | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/.github/workflows/vllm-benchmark.yml b/.github/workflows/vllm-benchmark.yml index d8f55c5..ae781dd 100644 --- a/.github/workflows/vllm-benchmark.yml +++ b/.github/workflows/vllm-benchmark.yml @@ -53,7 +53,7 @@ jobs: shell: bash env: MODELS: ${{ inputs.models || '' }} - RUNNERS: ${{ inputs.runners || '' }} + RUNNERS: ${{ inputs.runners || 'spr' }} run: | set -eux @@ -302,3 +302,6 @@ jobs: --device-name "${DEVICE_NAME}" \ --device-type "${SANITIZED_DEVICE_TYPE}" \ --model "${MODELS//\//_}" + + # DEBUG + sleep 1800 From 4d1731a06a09cf53ddc2ce7188c716a35f355eff Mon Sep 17 00:00:00 2001 From: Huy Do Date: Thu, 17 Jul 2025 01:33:20 -0700 Subject: [PATCH 2/3] [no ci] Does this work? Signed-off-by: Huy Do --- .github/scripts/upload_benchmark_results.py | 3 ++- .github/workflows/vllm-benchmark.yml | 3 --- 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/.github/scripts/upload_benchmark_results.py b/.github/scripts/upload_benchmark_results.py index 63e5e58..b8cf7c7 100755 --- a/.github/scripts/upload_benchmark_results.py +++ b/.github/scripts/upload_benchmark_results.py @@ -1,5 +1,6 @@ #!/usr/bin/env python3 +import itertools import requests import glob import gzip @@ -133,7 +134,7 @@ def get_git_metadata(repo_dir: str) -> Tuple[str, str]: ) except TypeError as e: # This is a detached HEAD, try to find out where the commit comes from - for head in repo.heads: + for head in itertools.chain(repo.heads, repo.refs): info(f"Check commits from {head.name}") for commit in repo.iter_commits(head): if commit.hexsha == hexsha: diff --git a/.github/workflows/vllm-benchmark.yml b/.github/workflows/vllm-benchmark.yml index ae781dd..79ab8fb 100644 --- a/.github/workflows/vllm-benchmark.yml +++ b/.github/workflows/vllm-benchmark.yml @@ -302,6 +302,3 @@ jobs: --device-name "${DEVICE_NAME}" \ --device-type "${SANITIZED_DEVICE_TYPE}" \ --model "${MODELS//\//_}" - - # DEBUG - sleep 1800 From 85ad90dad4833df951596027f5eef75a662ea252 Mon Sep 17 00:00:00 2001 From: Huy Do Date: Thu, 17 Jul 2025 01:40:18 -0700 Subject: [PATCH 3/3] [no ci] Ready for review Signed-off-by: Huy Do --- .github/workflows/vllm-benchmark.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/vllm-benchmark.yml b/.github/workflows/vllm-benchmark.yml index 79ab8fb..d8f55c5 100644 --- a/.github/workflows/vllm-benchmark.yml +++ b/.github/workflows/vllm-benchmark.yml @@ -53,7 +53,7 @@ jobs: shell: bash env: MODELS: ${{ inputs.models || '' }} - RUNNERS: ${{ inputs.runners || 'spr' }} + RUNNERS: ${{ inputs.runners || '' }} run: | set -eux