Skip to content

Conflicting comments and enforcement conditions in transport/tcp/buffer.cc #421

@l6l

Description

@l6l

Near transport/tcp/buffer.cc:91:

  if (pair_->isSync()) {
    // The send operation must flush all data to the underlying socket
    // and then call handleSendCompletion. Therefore, the number of
    // send completions must always be positive when calling waitSend.
    GLOO_ENFORCE_GE(1, sendCompletions_);

The comments says sendCompletions must be positive, while the enforcement condition says 1>=sendCompletions. It seems to me the latter is wrong.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions