Skip to content

Convert pthreadpool to ExternalProject #12468

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: gh/swolchok/505/head
Choose a base branch
from

Conversation

swolchok
Copy link
Contributor

As with the previous PR #12425, I think this is needed to get EXPORT
to work.

[ghstack-poisoned]
Copy link

pytorch-bot bot commented Jul 14, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/12468

Note: Links to docs will display an error until the docs builds have been completed.

❌ 5 New Failures, 1 Cancelled Job, 5 Unrelated Failures

As of commit 4fd7372 with merge base b9bb3c1 (image):

NEW FAILURES - The following jobs have failed:

CANCELLED JOB - The following job was cancelled. Please retry:

BROKEN TRUNK - The following jobs failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@swolchok
Copy link
Contributor Author

test-llama-torchao-lowbit is failing with inability to #include <pthreadpool.h>, looks like we need to configure it to install

manywheel build is failing with an XNNPACK issue, unclear why it's not failing on previous rev: gmake[3]: *** No rule to make target 'backends/xnnpack/XNNPACK/install/lib/libXNNPACK.a', needed by '_portable_lib.cpython-310-x86_64-linux-gnu.so'. Stop. https://github.com/pytorch/executorch/actions/runs/16280451716/job/45968809700?pr=12468#step:15:1109

@swolchok swolchok marked this pull request as draft July 15, 2025 17:20
[ghstack-poisoned]
swolchok added a commit that referenced this pull request Jul 15, 2025
As with the previous PR #12425, I think this is needed to get EXPORT
to work.

ghstack-source-id: 2286359
ghstack-comment-id: 3071359023
Pull-Request: #12468
@swolchok swolchok added the release notes: none Do not include this in the release notes label Jul 15, 2025
[ghstack-poisoned]
swolchok added a commit that referenced this pull request Jul 15, 2025
As with the previous PR #12425, I think this is needed to get EXPORT
to work.

ghstack-source-id: 0f66acd
ghstack-comment-id: 3071359023
Pull-Request: #12468
@swolchok
Copy link
Contributor Author

mac unittests are segfaulting, needs debugging

[ghstack-poisoned]
swolchok added a commit that referenced this pull request Jul 15, 2025
Following PR (#12425) broke Linux manywheel and there was no way to
repro it on that PR; I just happened to catch it because the PR after
that (#12468) triggered the manywheel build.
[ghstack-poisoned]
@swolchok swolchok marked this pull request as ready for review July 15, 2025 21:23
lucylq pushed a commit that referenced this pull request Jul 17, 2025
Following PR (#12425) broke Linux manywheel and there was no way to
repro it on that PR; I just happened to catch it because the PR after
that (#12468) triggered the manywheel build.
[ghstack-poisoned]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ciflow/binaries ciflow/trunk CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. release notes: none Do not include this in the release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants