You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
reacted with thumbs up emoji reacted with thumbs down emoji reacted with laugh emoji reacted with hooray emoji reacted with confused emoji reacted with heart emoji reacted with rocket emoji reacted with eyes emoji
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
-
I read the code of get_8a8w_qnn_ptq_config, I found the minimum values of weight quantization is a one more than activation and bias quantization, please refer to:
https://github.com/pytorch/executorch/blob/main/backends/qualcomm/quantizer/qconfig.py#L88
weight_quantization_spec = QuantizationSpec(
dtype=torch.int8,
quant_min=torch.iinfo(torch.int8).min + 1,
quant_max=torch.iinfo(torch.int8).max,
qscheme=torch.per_tensor_symmetric,
ch_axis=0,
observer_or_fake_quant_ctr=MinMaxObserver.with_args(**extra_args),
)
I think the difference between the minimum values of weight quantization and the activation and bias quantization should not be the const 1.
And there should check the minimum value should be lower than the maximum value firstly.
I just try to make the code be best, could you please explain the code?
Thanks for the great work of executorch.
Beta Was this translation helpful? Give feedback.
All reactions