Skip to content

Commit 99dd8eb

Browse files
committed
Format all Java files with google-java-format; add directories to lint workflow
1 parent 45d7520 commit 99dd8eb

File tree

3 files changed

+19
-15
lines changed

3 files changed

+19
-15
lines changed

.github/workflows/lint.yml

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -83,8 +83,13 @@ jobs:
8383
script: |
8484
FILES_NEEDS_FORMAT=$(/opt/google-java-format -n \
8585
extension/android/executorch_android/src/main/java/org/pytorch/executorch/*.java \
86+
extension/android/executorch_android/src/main/java/org/pytorch/executorch/extension/llm/*.java \
87+
extension/android/executorch_android/src/main/java/org/pytorch/executorch/annotations/*.java \
88+
extension/android/executorch_android/src/androidTest/java/org/pytorch/executorch/*.java \
8689
examples/demo-apps/android/LlamaDemo/app/src/main/java/com/example/executorchllamademo/*.java \
87-
extension/benchmark/android/benchmark/app/src/main/java/org/pytorch/minibench/*.java)
90+
examples/demo-apps/android/LlamaDemo/app/src/androidTest/java/com/example/executorchllamademo/*.java \
91+
extension/benchmark/android/benchmark/app/src/main/java/org/pytorch/minibench/*.java \
92+
extension/benchmark/android/benchmark/app/src/androidTest/java/org/pytorch/minibench/*.java)
8893
if [ -n "$FILES_NEEDS_FORMAT" ]; then
8994
echo "Warning: The following files need formatting. Please use google-java-format."
9095
echo "Use a binary from https://github.com/google/google-java-format/releases/"

extension/android/executorch_android/src/androidTest/java/org/pytorch/executorch/RuntimeInstrumentationTest.java

Lines changed: 13 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -11,27 +11,27 @@
1111
import static org.junit.Assert.assertNotNull;
1212

1313
import androidx.test.ext.junit.runners.AndroidJUnit4;
14-
import org.junit.runner.RunWith;
1514
import org.junit.Test;
15+
import org.junit.runner.RunWith;
1616

1717
/** Unit tests for {@link ExecuTorchRuntime}. */
1818
@RunWith(AndroidJUnit4.class)
1919
public class RuntimeInstrumentationTest {
2020

21-
@Test
22-
public void testRuntimeApi() {
23-
String[] ops = ExecuTorchRuntime.getRegisteredOps();
24-
String[] backends = ExecuTorchRuntime.getRegisteredBackends();
21+
@Test
22+
public void testRuntimeApi() {
23+
String[] ops = ExecuTorchRuntime.getRegisteredOps();
24+
String[] backends = ExecuTorchRuntime.getRegisteredBackends();
2525

26-
assertNotNull(ops);
27-
assertNotNull(backends);
26+
assertNotNull(ops);
27+
assertNotNull(backends);
2828

29-
for (String op : ops) {
30-
assertNotNull(op);
31-
}
29+
for (String op : ops) {
30+
assertNotNull(op);
31+
}
3232

33-
for (String backend : backends) {
34-
assertNotNull(backend);
35-
}
33+
for (String backend : backends) {
34+
assertNotNull(backend);
3635
}
36+
}
3737
}

extension/android/executorch_android/src/main/java/org/pytorch/executorch/extension/llm/LlmModule.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,6 @@
1111
import com.facebook.jni.HybridData;
1212
import com.facebook.jni.annotations.DoNotStrip;
1313
import java.io.File;
14-
1514
import org.pytorch.executorch.ExecuTorchRuntime;
1615
import org.pytorch.executorch.annotations.Experimental;
1716

0 commit comments

Comments
 (0)