@@ -112,11 +112,12 @@ set(CMAKE_SKIP_BUILD_RPATH OFF)
112
112
set (CMAKE_BUILD_WITH_INSTALL_RPATH ON )
113
113
# Automatically add all linked folders that are NOT in the build directory to
114
114
# the rpath (per library?)
115
- # TODO: Doesn't work for us right now because we are
116
- # not installing .so's into the correct locations. For example we have
117
- # libcustom_ops_aot_lib.so depending on _portable_lib.so, which was eventually
118
- # put under <site-packages>/executorch/extension/pybindings/ but this rpath is
119
- # not automatically added because at build time it seems `portable_lib` is being
115
+ #
116
+ # TODO: Doesn't work for us right now because we are not installing .so's into
117
+ # the correct locations. For example we have libcustom_ops_aot_lib.so depending
118
+ # on _portable_lib.so, which was eventually put under
119
+ # <site-packages>/executorch/extension/pybindings/ but this rpath is not
120
+ # automatically added because at build time it seems `portable_lib` is being
120
121
# built under the same directory, so no extra rpath is being added. To properly
121
122
# fix this we need to install `portable_lib` into the correct path.
122
123
set (CMAKE_INSTALL_RPATH_USE_LINK_PATH ON )
@@ -321,8 +322,9 @@ if(EXECUTORCH_USE_CPP_CODE_COVERAGE)
321
322
" -fprofile-instr-generate -fcoverage-mapping"
322
323
)
323
324
else ()
324
- message (FATAL_ERROR
325
- "Code coverage for compiler ${CMAKE_CXX_COMPILER_ID} is unsupported"
325
+ message (
326
+ FATAL_ERROR
327
+ "Code coverage for compiler ${CMAKE_CXX_COMPILER_ID} is unsupported"
326
328
)
327
329
endif ()
328
330
endif ()
@@ -633,8 +635,8 @@ if(EXECUTORCH_BUILD_PYBIND)
633
635
endif ()
634
636
635
637
if (EXECUTORCH_BUILD_XNNPACK )
636
- # need to explicitly specify XNNPACK and xnnpack-microkernels-prod here otherwise
637
- # uses XNNPACK and microkernel-prod symbols from libtorch_cpu
638
+ # need to explicitly specify XNNPACK and xnnpack-microkernels-prod here
639
+ # otherwise uses XNNPACK and microkernel-prod symbols from libtorch_cpu
638
640
list (APPEND _dep_libs xnnpack_backend XNNPACK xnnpack-microkernels-prod )
639
641
endif ()
640
642
0 commit comments