Skip to content

Commit 68887a7

Browse files
committed
Don't force extension_module to build as a shared library by default
Other targets seem to just use whatever the default configuration is. Make this one work the same. ghstack-source-id: c2b7580 ghstack-comment-id: 3046953486 Pull-Request-resolved: #12257
1 parent d952326 commit 68887a7

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

extension/module/CMakeLists.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ if(CMAKE_TOOLCHAIN_IOS
2525
# duplicated registration when using shared lib
2626
add_library(extension_module STATIC ${_extension_module__srcs})
2727
else()
28-
add_library(extension_module SHARED ${_extension_module__srcs})
28+
add_library(extension_module ${_extension_module__srcs})
2929
endif()
3030
target_link_libraries(extension_module PRIVATE executorch_core extension_data_loader extension_flat_tensor)
3131
target_include_directories(extension_module PUBLIC ${EXECUTORCH_ROOT}/..)

0 commit comments

Comments
 (0)