[Suggestion] Implement GaussianMixturePosterior via torch.distributions.MixtureSameFamily #2244
Replies: 2 comments
-
Thanks for the suggestion - overall this makes sense to me conceptually, but we should look a bit deeper into how this would interact with some of the specifics in gpytorch's |
Beta Was this translation helpful? Give feedback.
-
Also worth noting that the current design goes hand in hand with the implementation of |
Beta Was this translation helpful? Give feedback.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
-
Currently,
GaussianMixturePosterior
is implemented as aMultivariateNormal
distributions with abatch_shape
equal to the number of components in the Gaussian mixture. I wonder if it would make more sense (and be more semantically accurate) to use aMixtureSameFamily
distribution withMultivariateNormal
components without abatch_shape
. An additional benefit is thatMixtureSameFamily
already implements themean
andvariance
functions. (The quantile function would still need to be implemented within BoTorch.)Beta Was this translation helpful? Give feedback.
All reactions