Skip to content

Commit c7cddec

Browse files
Matt Gallowayfacebook-github-bot
Matt Galloway
authored andcommitted
Fix compiling with Xcode 14.3 (#1648)
Summary: Pull Request resolved: #1648 This hack is not needed in Xcode 14.3 anymore, where the clang version is 14.0.3. So change the workaround to only include up to 14.0.2. Reviewed By: MatzeB Differential Revision: D44130421 fbshipit-source-id: 1fb2948567941bdf6ee9487ccfaa9dfb2caf92dd
1 parent 39c5aa4 commit c7cddec

File tree

1 file changed

+3
-2
lines changed

1 file changed

+3
-2
lines changed

src/InlineAsmDefines.h

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,13 +10,14 @@
1010
// We need to do a hack in inline assembly in some clang versions where we have
1111
// to do `.intel_syntax noprefix`. This was fixed in clang in
1212
// https://reviews.llvm.org/D113707, which made it into clang-14, but not in
13-
// Apple's clang-14 that ships with Xcode 14.
13+
// Apple's clang-14 that ships with Xcode 14.2. It was first fixed in Xcode 14.3
14+
// where the clang version is 14.0.3.
1415
#if defined(__clang__)
1516

1617
#if ( \
1718
defined(__apple_build_version__) || \
1819
(defined(__has_builtin) && __has_builtin(__builtin_pika_xxhash64))) && \
19-
(__clang_major__ < 15)
20+
(__clang_major__ < 15 && __clang_minor__ == 0 && __clang_patchlevel__ < 3)
2021
#define FBGEMM_USE_CLANG_INTEL_SYNTAX_ASM_HACK 1
2122
#elif (__clang_major__ < 14)
2223
#define FBGEMM_USE_CLANG_INTEL_SYNTAX_ASM_HACK 1

0 commit comments

Comments
 (0)