Skip to content

Commit 5d24e24

Browse files
cthifacebook-github-bot
authored andcommitted
Fix quantize_bench in OSS (#4463)
Summary: Pull Request resolved: #4463 X-link: facebookresearch/FBGEMM#1522 Currently quantize_bench is broken in OSS, this was because we slightly changed how the python files are installed in the cmake build. Right now they will be installed to `fbgemm_gpu/experimental/bench`, which would break the import on OSS as the directory structure doesn't match. I think simplest thing is just to install it into `fbgemm_gpu/experimental/gen_ai/bench`, and then add back the bench part to fbcode. Reviewed By: jiawenliu64 Differential Revision: D78025117 fbshipit-source-id: e9fe5c83b5bdf3cc1e461d28bc8e5293833a8a6c
1 parent 2763eba commit 5d24e24

File tree

3 files changed

+11
-4
lines changed

3 files changed

+11
-4
lines changed

fbgemm_gpu/experimental/gen_ai/CMakeLists.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -174,7 +174,7 @@ add_to_package(
174174

175175
install(
176176
DIRECTORY bench
177-
DESTINATION fbgemm_gpu/experimental)
177+
DESTINATION fbgemm_gpu/experimental/gen_ai)
178178

179179
install(
180180
DIRECTORY gen_ai

fbgemm_gpu/experimental/gen_ai/bench/quantize_bench.py

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,10 @@ def __init__(self, *args, **kwargs):
2929
super().__init__()
3030

3131

32-
from fbgemm_gpu.experimental.gen_ai.quantize_ops import get_quantize_ops, QuantizeOpBase
32+
from fbgemm_gpu.experimental.gen_ai.bench.quantize_ops import (
33+
get_quantize_ops,
34+
QuantizeOpBase,
35+
)
3336

3437

3538
def generate_group_tensor(G, M):

fbgemm_gpu/experimental/gen_ai/bench/quantize_ops.py

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -41,8 +41,12 @@
4141
quantize_int4_preshuffle,
4242
)
4343

44-
from gen_ai.llm_inference.fb.llm.kernel.rms_norm import rms_norm
45-
from gen_ai.llm_inference.fb.llm.kernel.silu_mul import silu_mul
44+
try:
45+
from gen_ai.llm_inference.fb.llm.kernel.rms_norm import rms_norm
46+
from gen_ai.llm_inference.fb.llm.kernel.silu_mul import silu_mul
47+
except ImportError:
48+
# Above is used for some experiments, but the quantize is not relying on them. Okay to just skip.
49+
pass
4650

4751
try:
4852
from tinygemm.utils import group_quantize_tensor

0 commit comments

Comments
 (0)