Skip to content

Commit 90977e9

Browse files
njriasanfacebook-github-bot
authored andcommitted
Fix metrics collection with --bypass-fail
Summary: Fixes an issue where computing the average with `--bypass-fail` will fail if a subset of the rows are None as it will revert `avg_row[col_num]` to None. Reviewed By: xuzhao9 Differential Revision: D77949601 fbshipit-source-id: 3ff3d0491c4e3ff5ba2e652e4fad154067fa9707
1 parent 89cc4cf commit 90977e9

File tree

1 file changed

+8
-10
lines changed

1 file changed

+8
-10
lines changed

tritonbench/utils/triton_op.py

Lines changed: 8 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -351,11 +351,10 @@ def select_metric(backend, m):
351351
if len(avg_row) <= col_num:
352352
avg_row.append(next_val if isinstance(next_val, Number) else None)
353353
else:
354-
avg_row[col_num] = (
355-
avg_row[col_num] + next_val
356-
if isinstance(next_val, Number)
357-
else None
358-
)
354+
if avg_row[col_num] is None:
355+
avg_row[col_num] = next_val
356+
elif isinstance(next_val, Number):
357+
avg_row[col_num] = avg_row[col_num] + next_val
359358
col_num += 1
360359
for backend in backends:
361360
if x_val == "hashes" and len(hashes) > 0:
@@ -381,11 +380,10 @@ def select_metric(backend, m):
381380
metric_val if isinstance(metric_val, Number) else None
382381
)
383382
else:
384-
avg_row[col_num] = (
385-
avg_row[col_num] + metric_val
386-
if isinstance(metric_val, Number)
387-
else None
388-
)
383+
if avg_row[col_num] is None:
384+
avg_row[col_num] = metric_val
385+
elif isinstance(metric_val, Number):
386+
avg_row[col_num] = avg_row[col_num] + metric_val
389387
col_num += 1
390388
table.append(row)
391389

0 commit comments

Comments
 (0)