From afdac74fe51bf4c69edbf2a7b93dac5f660dcfef Mon Sep 17 00:00:00 2001 From: Peng Zhang Date: Tue, 15 Jul 2025 07:55:15 -0700 Subject: [PATCH] Clean up unused code and stale comment (#530) Summary: See comments added in the diff for why removing them. Reviewed By: suo Differential Revision: D78295862 --- hyperactor_mesh/src/actor_mesh.rs | 1 - hyperactor_mesh/src/comm.rs | 2 -- hyperactor_mesh/src/comm/multicast.rs | 5 ----- 3 files changed, 8 deletions(-) diff --git a/hyperactor_mesh/src/actor_mesh.rs b/hyperactor_mesh/src/actor_mesh.rs index 81ca8bae..0bf21028 100644 --- a/hyperactor_mesh/src/actor_mesh.rs +++ b/hyperactor_mesh/src/actor_mesh.rs @@ -82,7 +82,6 @@ where sender.clone(), actor_mesh_shape.clone(), message, - None, // TODO: reducer typehash )?; comm_actor_ref.send( diff --git a/hyperactor_mesh/src/comm.rs b/hyperactor_mesh/src/comm.rs index d2408d70..c1ec901d 100644 --- a/hyperactor_mesh/src/comm.rs +++ b/hyperactor_mesh/src/comm.rs @@ -256,8 +256,6 @@ impl CommActor { message.shape().clone(), message.sender().clone(), ); - // TODO(pzhang) split reply ports so children can reply to this comm - // actor instead of parent. cx.post( cx.self_id() .proc_id() diff --git a/hyperactor_mesh/src/comm/multicast.rs b/hyperactor_mesh/src/comm/multicast.rs index 700c5531..4f9792f3 100644 --- a/hyperactor_mesh/src/comm/multicast.rs +++ b/hyperactor_mesh/src/comm/multicast.rs @@ -54,8 +54,6 @@ pub struct CastMessageEnvelope { dest_port: DestinationPort, /// The serialized message. data: ErasedUnbound, - /// typehash of the reducer used to accumulate the message in split ports. - pub reducer_typehash: Option, /// The shape of the cast. shape: Shape, } @@ -67,7 +65,6 @@ impl CastMessageEnvelope { sender: ActorId, shape: Shape, message: M, - reducer_typehash: Option, ) -> Result where A: RemoteActor + RemoteHandles>, @@ -80,7 +77,6 @@ impl CastMessageEnvelope { sender, dest_port: DestinationPort::new::(actor_name), data, - reducer_typehash, shape, }) } @@ -100,7 +96,6 @@ impl CastMessageEnvelope { sender, dest_port, data: ErasedUnbound::new(data), - reducer_typehash: None, shape, } }