remove our custom signal handlers (#385)

Summary:
Pull Request resolved: #385

These need to be written quite carefully as they need to be async-signal-safe (no log, no printf, no malloc). Let's just not even try, and instead rely on the standard fb implementation which has been worked over forever.

Normally `#[fbinit]` will do this on the main entry point, but because bootstrap_main is a Python entry point that we spawn via the ProcessAllocator we need to call `initFacebook` there as well.
ghstack-source-id: 293873376
exported-using-ghexport

Reviewed By: vidhyav, mariusae

Differential Revision: D77565855

fbshipit-source-id: c5a5f6a3ec180879e4df3544303dcbbcb0ba2756

Author: suo

hyperactor/Cargo.toml

@@ -32,7 +32,6 @@ hyperactor_macros = { version = "0.0.0", path = "../hyperactor_macros" }
 hyperactor_telemetry = { version = "0.0.0", path = "../hyperactor_telemetry" }
 inventory = "0.3.8"
 lazy_static = { version = "1.5", features = ["spin_no_std"], default-features = false }
-libc = "0.2.139"
 ndslice = { version = "0.0.0", path = "../ndslice" }
 nix = { version = "0.29.0", features = ["dir", "event", "hostname", "inotify", "ioctl", "mman", "mount", "net", "poll", "ptrace", "reboot", "resource", "sched", "signal", "term", "time", "user", "zerocopy"] }
 opentelemetry = "0.29"

hyperactor/src/init.rs

@@ -37,41 +37,10 @@ pub fn initialize(handle: tokio::runtime::Handle) {
 
     panic_handler::set_panic_hook();
     hyperactor_telemetry::initialize_logging(ClockKind::default());
-    #[cfg(target_os = "linux")]
-    linux::initialize();
 }
 
 /// Initialize the Hyperactor runtime using the current tokio runtime handle.
 pub fn initialize_with_current_runtime() {
     let handle = tokio::runtime::Handle::current();
     initialize(handle);
 }
-
-#[cfg(target_os = "linux")]
-mod linux {
-    use std::backtrace::Backtrace;
-
-    use nix::sys::signal::SigHandler;
-
-    pub(crate) fn initialize() {
-        // Safety: Because I want to
-        unsafe {
-            extern "C" fn handle_fatal_signal(signo: libc::c_int) {
-                let bt = Backtrace::force_capture();
-                let signame = nix::sys::signal::Signal::try_from(signo).expect("unknown signal");
-                tracing::error!("stacktrace"= %bt, "fatal signal {signo}:{signame} received");
-                std::process::exit(1);
-            }
-            nix::sys::signal::signal(
-                nix::sys::signal::SIGABRT,
-                SigHandler::Handler(handle_fatal_signal),
-            )
-            .expect("unable to register signal handler");
-            nix::sys::signal::signal(
-                nix::sys::signal::SIGSEGV,
-                SigHandler::Handler(handle_fatal_signal),
-            )
-            .expect("unable to register signal handler");
-        }
-    }
-}

monarch_hyperactor/Cargo.toml

@@ -12,6 +12,7 @@ anyhow = "1.0.98"
 async-trait = "0.1.86"
 bincode = "1.3.3"
 clap = { version = "4.5.38", features = ["derive", "env", "string", "unicode", "wrap_help"] }
+fbinit = { version = "0.2.0", git = "https://github.com/facebookexperimental/rust-shed.git", branch = "main" }
 hyperactor = { version = "0.0.0", path = "../hyperactor" }
 hyperactor_extension = { version = "0.0.0", path = "../hyperactor_extension" }
 hyperactor_mesh = { version = "0.0.0", path = "../hyperactor_mesh" }

monarch_hyperactor/src/bootstrap.rs

@@ -20,8 +20,18 @@ use pyo3::wrap_pyfunction;
 #[pyfunction]
 #[pyo3(signature = ())]
 pub fn bootstrap_main(py: Python) -> PyResult<Bound<PyAny>> {
+    // SAFETY: this is a correct use of this function.
+    let _ = unsafe {
+        fbinit::perform_init();
+    };
+
     hyperactor::tracing::debug!("entering async bootstrap");
     pyo3_async_runtimes::tokio::future_into_py::<_, ()>(py, async move {
+        // SAFETY:
+        // - Only one of these is ever created.
+        // - This is the entry point of this program, so this will be dropped when
+        // no more FB C++ code is running.
+        let _destroy_guard = unsafe { fbinit::DestroyGuard::new() };
         bootstrap_or_die().await;
     })
 }