Skip to content

Commit dd7256d

Browse files
pzhan9facebook-github-bot
authored andcommitted
Clean up unused code and stale comment
Summary: See comments added in the diff for why removing them. Differential Revision: D78295862
1 parent 2d369e1 commit dd7256d

File tree

3 files changed

+0
-8
lines changed

3 files changed

+0
-8
lines changed

hyperactor_mesh/src/actor_mesh.rs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -82,7 +82,6 @@ where
8282
sender.clone(),
8383
actor_mesh_shape.clone(),
8484
message,
85-
None, // TODO: reducer typehash
8685
)?;
8786

8887
comm_actor_ref.send(

hyperactor_mesh/src/comm.rs

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -256,8 +256,6 @@ impl CommActor {
256256
message.shape().clone(),
257257
message.sender().clone(),
258258
);
259-
// TODO(pzhang) split reply ports so children can reply to this comm
260-
// actor instead of parent.
261259
cx.post(
262260
cx.self_id()
263261
.proc_id()

hyperactor_mesh/src/comm/multicast.rs

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -54,8 +54,6 @@ pub struct CastMessageEnvelope {
5454
dest_port: DestinationPort,
5555
/// The serialized message.
5656
data: ErasedUnbound,
57-
/// typehash of the reducer used to accumulate the message in split ports.
58-
pub reducer_typehash: Option<u64>,
5957
/// The shape of the cast.
6058
shape: Shape,
6159
}
@@ -67,7 +65,6 @@ impl CastMessageEnvelope {
6765
sender: ActorId,
6866
shape: Shape,
6967
message: M,
70-
reducer_typehash: Option<u64>,
7168
) -> Result<Self, anyhow::Error>
7269
where
7370
A: RemoteActor + RemoteHandles<IndexedErasedUnbound<M>>,
@@ -80,7 +77,6 @@ impl CastMessageEnvelope {
8077
sender,
8178
dest_port: DestinationPort::new::<A, M>(actor_name),
8279
data,
83-
reducer_typehash,
8480
shape,
8581
})
8682
}
@@ -100,7 +96,6 @@ impl CastMessageEnvelope {
10096
sender,
10197
dest_port,
10298
data: ErasedUnbound::new(data),
103-
reducer_typehash: None,
10499
shape,
105100
}
106101
}

0 commit comments

Comments
 (0)