Skip to content

Commit cac4f94

Browse files
committed
[monarch] fold hyperactor_extension into monarch_hyperactor
This originally was separated out as an artifact of dual extensions, now that there is only one hyperactor_extension we don't need to do that. Differential Revision: [D77945980](https://our.internmc.facebook.com/intern/diff/D77945980/) ghstack-source-id: 294902065 Pull Request resolved: #464
1 parent e4a35bb commit cac4f94

File tree

24 files changed

+212
-413
lines changed

24 files changed

+212
-413
lines changed

actor_extension/Cargo.toml

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,11 +16,12 @@ crate-type = ["cdylib"]
1616
anyhow = "1.0.98"
1717
bincode = "1.3.3"
1818
hyperactor = { version = "0.0.0", path = "../hyperactor" }
19-
hyperactor_extension = { version = "0.0.0", path = "../hyperactor_extension" }
2019
hyperactor_mesh = { version = "0.0.0", path = "../hyperactor_mesh" }
20+
hyperactor_telemetry = { version = "0.0.0", path = "../hyperactor_telemetry" }
2121
libc = "0.2.139"
2222
monarch_hyperactor = { version = "0.0.0", path = "../monarch_hyperactor" }
2323
pyo3 = { version = "0.24", features = ["anyhow", "multiple-pymethods"] }
2424
pyo3-async-runtimes = { version = "0.24", features = ["attributes", "tokio-runtime"] }
2525
serde = { version = "1.0.185", features = ["derive", "rc"] }
2626
tokio = { version = "1.45.0", features = ["full", "test-util", "tracing"] }
27+
tracing = { version = "0.1.41", features = ["attributes", "valuable"] }

actor_extension/src/lib.rs

Lines changed: 2 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,7 @@ use pyo3::prelude::*;
1515
mod blocking;
1616
mod code_sync;
1717
mod panic;
18+
mod telemetry;
1819

1920
#[cfg(fbcode_build)]
2021
mod meta;
@@ -105,14 +106,7 @@ pub fn mod_init(module: &Bound<'_, PyModule>) -> PyResult<()> {
105106
module,
106107
"monarch_hyperactor.runtime",
107108
)?)?;
108-
hyperactor_extension::alloc::register_python_bindings(&get_or_add_new_module(
109-
module,
110-
"hyperactor_extension.alloc",
111-
)?)?;
112-
hyperactor_extension::telemetry::register_python_bindings(&get_or_add_new_module(
113-
module,
114-
"hyperactor_extension.telemetry",
115-
)?)?;
109+
telemetry::register_python_bindings(&get_or_add_new_module(module, "telemetry")?)?;
116110
crate::panic::register_python_bindings(&get_or_add_new_module(module, "panic")?)?;
117111

118112
crate::blocking::register_python_bindings(&get_or_add_new_module(module, "blocking")?)?;

hyperactor_extension/src/telemetry.rs renamed to actor_extension/src/telemetry.rs

Lines changed: 7 additions & 25 deletions
Original file line numberDiff line numberDiff line change
@@ -113,7 +113,7 @@ pub fn use_sim_clock() -> PyResult<()> {
113113
#[pyclass(
114114
unsendable,
115115
subclass,
116-
module = "monarch._src.actor._extension.hyperactor_extension.telemetry"
116+
module = "monarch._src.actor._extension.telemetry"
117117
)]
118118
struct PySpan {
119119
span: tracing::span::EnteredSpan,
@@ -140,46 +140,28 @@ use pyo3::types::PyModule;
140140
pub fn register_python_bindings(module: &Bound<'_, PyModule>) -> PyResult<()> {
141141
// Register the forward_to_tracing function
142142
let f = wrap_pyfunction!(forward_to_tracing, module)?;
143-
f.setattr(
144-
"__module__",
145-
"monarch._src.actor._extension.hyperactor_extension.telemetry",
146-
)?;
143+
f.setattr("__module__", "monarch._src.actor._extension.telemetry")?;
147144
module.add_function(f)?;
148145

149146
// Register the span-related functions
150147
let enter_span_fn = wrap_pyfunction!(enter_span, module)?;
151-
enter_span_fn.setattr(
152-
"__module__",
153-
"monarch._src.actor._extension.hyperactor_extension.telemetry",
154-
)?;
148+
enter_span_fn.setattr("__module__", "monarch._src.actor._extension.telemetry")?;
155149
module.add_function(enter_span_fn)?;
156150

157151
let exit_span_fn = wrap_pyfunction!(exit_span, module)?;
158-
exit_span_fn.setattr(
159-
"__module__",
160-
"monarch._src.actor._extension.hyperactor_extension.telemetry",
161-
)?;
152+
exit_span_fn.setattr("__module__", "monarch._src.actor._extension.telemetry")?;
162153
module.add_function(exit_span_fn)?;
163154

164155
let get_current_span_id_fn = wrap_pyfunction!(get_current_span_id, module)?;
165-
get_current_span_id_fn.setattr(
166-
"__module__",
167-
"monarch._src.actor._extension.hyperactor_extension.telemetry",
168-
)?;
156+
get_current_span_id_fn.setattr("__module__", "monarch._src.actor._extension.telemetry")?;
169157
module.add_function(get_current_span_id_fn)?;
170158

171159
let use_real_clock_fn = wrap_pyfunction!(use_real_clock, module)?;
172-
use_real_clock_fn.setattr(
173-
"__module__",
174-
"monarch._src.actor._extension.hyperactor_extension.telemetry",
175-
)?;
160+
use_real_clock_fn.setattr("__module__", "monarch._src.actor._extension.telemetry")?;
176161
module.add_function(use_real_clock_fn)?;
177162

178163
let use_sim_clock_fn = wrap_pyfunction!(use_sim_clock, module)?;
179-
use_sim_clock_fn.setattr(
180-
"__module__",
181-
"monarch._src.actor._extension.hyperactor_extension.telemetry",
182-
)?;
164+
use_sim_clock_fn.setattr("__module__", "monarch._src.actor._extension.telemetry")?;
183165
module.add_function(use_sim_clock_fn)?;
184166

185167
module.add_class::<PySpan>()?;

hyperactor_extension/Cargo.toml

Lines changed: 0 additions & 17 deletions
This file was deleted.

hyperactor_extension/src/alloc.rs

Lines changed: 0 additions & 169 deletions
This file was deleted.

hyperactor_extension/src/lib.rs

Lines changed: 0 additions & 12 deletions
This file was deleted.

monarch_hyperactor/Cargo.toml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,6 @@ clap = { version = "4.5.38", features = ["derive", "env", "string", "unicode", "
1515
erased-serde = "0.3.27"
1616
fbinit = { version = "0.2.0", git = "https://github.com/facebookexperimental/rust-shed.git", branch = "main" }
1717
hyperactor = { version = "0.0.0", path = "../hyperactor" }
18-
hyperactor_extension = { version = "0.0.0", path = "../hyperactor_extension" }
1918
hyperactor_mesh = { version = "0.0.0", path = "../hyperactor_mesh" }
2019
hyperactor_multiprocess = { version = "0.0.0", path = "../hyperactor_multiprocess" }
2120
hyperactor_telemetry = { version = "0.0.0", path = "../hyperactor_telemetry" }

0 commit comments

Comments
 (0)