slew of lints (#503)

Summary:
Pull Request resolved: #503

clear some lints.

Reviewed By: mariusae

Differential Revision: D78168676

fbshipit-source-id: 45fa3514434dfa2db5316ee14fe2faa26bbbf572

Author: shayne-fletcher

hyperactor/src/accum.rs

@@ -19,7 +19,6 @@ use serde::de::DeserializeOwned;
 use crate as hyperactor; // for macros
 use crate::Named;
 use crate::data::Serialized;
-use crate::intern_typename;
 use crate::reference::Index;
 
 /// An accumulator is a object that accumulates updates into a state.

hyperactor/src/actor.rs

@@ -15,8 +15,6 @@ use std::fmt;
 use std::fmt::Debug;
 use std::future::Future;
 use std::future::IntoFuture;
-use std::hash::Hash;
-use std::marker::PhantomData;
 use std::pin::Pin;
 use std::sync::Arc;
 use std::time::SystemTime;
@@ -55,9 +53,7 @@ use crate::proc::InstanceCell;
 use crate::proc::Ports;
 use crate::proc::Proc;
 use crate::reference::ActorId;
-use crate::reference::GangId;
 use crate::reference::Index;
-use crate::reference::ProcId;
 use crate::supervision::ActorSupervisionEvent;
 
 pub mod remote;

hyperactor/src/message.rs

@@ -45,7 +45,6 @@ use crate::RemoteHandles;
 use crate::RemoteMessage;
 use crate::actor::RemoteActor;
 use crate::data::Serialized;
-use crate::intern_typename; // for macros
 
 /// An object `T` that is [`Unbind`] can extract a set of parameters from itself,
 /// and store in [`Bindings`]. The extracted parameters in [`Bindings`] can be

hyperactor_macros/tests/export.rs

@@ -14,7 +14,6 @@ use hyperactor::Handler;
 use hyperactor::Named;
 use hyperactor::PortRef;
 use hyperactor::Unbind;
-use hyperactor::data::intern_typename;
 use serde::Deserialize;
 
 use crate::Serialize;

hyperactor_mesh/src/comm.rs

@@ -33,7 +33,6 @@ use hyperactor::mailbox::UndeliverableMailboxSender;
 use hyperactor::mailbox::UndeliverableMessageError;
 use hyperactor::mailbox::monitored_return_handle;
 use hyperactor::reference::UnboundPort;
-use ndslice::Slice;
 use ndslice::selection::routing::RoutingFrame;
 use serde::Deserialize;
 use serde::Serialize;

monarch_hyperactor/src/actor.rs

@@ -28,7 +28,6 @@ use hyperactor::message::Unbind;
 use hyperactor_mesh::comm::multicast::CastInfo;
 use monarch_types::PickledPyObject;
 use monarch_types::SerializablePyErr;
-use ndslice::Shape;
 use pyo3::conversion::IntoPyObjectExt;
 use pyo3::exceptions::PyBaseException;
 use pyo3::exceptions::PyRuntimeError;

monarch_hyperactor/src/actor_mesh.rs

@@ -29,7 +29,7 @@ use crate::shape::PyShape;
     module = "monarch._rust_bindings.monarch_hyperactor.actor_mesh"
 )]
 pub struct PythonActorMesh {
-    pub inner: SharedCell<RootActorMesh<'static, PythonActor>>,
+    pub(super) inner: SharedCell<RootActorMesh<'static, PythonActor>>,
     pub client: PyMailbox,
     pub(super) _keepalive: Keepalive,
 }

monarch_hyperactor/src/mailbox.rs

@@ -313,7 +313,7 @@ impl PythonUndeliverablePortHandle {
     name = "PortRef",
     module = "monarch._rust_bindings.monarch_hyperactor.mailbox"
 )]
-pub(super) struct PythonPortRef {
+pub struct PythonPortRef {
     pub(crate) inner: PortRef<PythonMessage>,
 }
 
@@ -453,7 +453,7 @@ impl PythonOncePortHandle {
     name = "OncePortRef",
     module = "monarch._rust_bindings.monarch_hyperactor.mailbox"
 )]
-pub(crate) struct PythonOncePortRef {
+pub struct PythonOncePortRef {
     pub(crate) inner: Option<OncePortRef<PythonMessage>>,
 }
 

monarch_rdma/examples/parameter_server.rs

@@ -358,7 +358,7 @@ impl Handler<WorkerStep> for WorkerActor {
             .ps_grad_handle
             .as_ref()
             .expect("worker_actor should be initialized");
-        let mut lbuffer = owner_ref
+        let /*mut*/ lbuffer = owner_ref
             .request_buffer(
                 cx,
                 self.local_gradients.as_ptr() as usize,
@@ -391,7 +391,7 @@ impl Handler<WorkerUpdate> for WorkerActor {
             "[worker_actor_{}] pulling new weights from parameter server (before: {:?})",
             rank, self.weights_data,
         );
-        let mut lbuffer = self
+        let /*mut*/ lbuffer = self
             .rdma_manager
             .as_ref()
             .expect("Rmda Manager should have been initialized")

monarch_rdma/src/rdma_manager_actor.rs

@@ -506,7 +506,7 @@ mod tests {
             return Ok(());
         }
         let env = RdmaManagerTestEnv::setup(BSIZE, ("mlx5_0", "mlx5_4"), ("cpu", "cpu")).await?;
-        let mut rdma_handle_1 = env.rdma_handle_1.clone();
+        let /*mut*/ rdma_handle_1 = env.rdma_handle_1.clone();
         rdma_handle_1
             .read_into(&env.client_1.clone(), env.rdma_handle_2.clone(), 2)
             .await?;
@@ -527,7 +527,7 @@ mod tests {
             return Ok(());
         }
         let env = RdmaManagerTestEnv::setup(BSIZE, ("mlx5_0", "mlx5_4"), ("cuda:0", "cpu")).await?;
-        let mut rdma_handle_1 = env.rdma_handle_1.clone();
+        let /*mut*/ rdma_handle_1 = env.rdma_handle_1.clone();
         rdma_handle_1
             .read_into(&env.client_1.clone(), env.rdma_handle_2.clone(), 2)
             .await?;
@@ -549,7 +549,7 @@ mod tests {
         }
         let env =
             RdmaManagerTestEnv::setup(BSIZE, ("mlx5_0", "mlx5_4"), ("cuda:0", "cuda:1")).await?;
-        let mut rdma_handle_1 = env.rdma_handle_1.clone();
+        let /*mut*/ rdma_handle_1 = env.rdma_handle_1.clone();
         rdma_handle_1
             .read_into(&env.client_1.clone(), env.rdma_handle_2.clone(), 2)
             .await?;
@@ -571,7 +571,7 @@ mod tests {
             return Ok(());
         }
         let env = RdmaManagerTestEnv::setup(BSIZE, ("mlx5_0", "mlx5_4"), ("cuda:0", "cpu")).await?;
-        let mut rdma_handle_1 = env.rdma_handle_1.clone();
+        let /*mut*/ rdma_handle_1 = env.rdma_handle_1.clone();
         rdma_handle_1
             .read_into(&env.client_1.clone(), env.rdma_handle_2.clone(), 2)
             .await?;
@@ -592,7 +592,7 @@ mod tests {
             return Ok(());
         }
         let env = RdmaManagerTestEnv::setup(BSIZE, ("mlx5_0", "mlx5_4"), ("cpu", "cpu")).await?;
-        let mut rdma_handle_1 = env.rdma_handle_1.clone();
+        let /*mut*/ rdma_handle_1 = env.rdma_handle_1.clone();
         rdma_handle_1
             .write_from(&env.client_1.clone(), env.rdma_handle_2.clone(), 2)
             .await?;