Skip to content

Commit 750c058

Browse files
David Tolnayfacebook-github-bot
authored andcommitted
Simplify lazy_static dependency
Summary: 1. `lazy_static` has no default features so `default-features = false` has no effect. 2. The `spin_no_std` feature is not something that you would want in builds where a standard library synchronization primitive like `std::sync::Once` is available, only in the no-std universe, where it is already controlled by this: https://www.internalfb.com/code/fbsource/[5e45000999be0e3bb870baef8c9b7a1b5ddd0160]/third-party/rust/reindeer.toml?lines=435-438%2C440 The `spin_no_std` feature will sadly remain enabled for now due to a misguided use of it in the `num-bigint-dig` crate, which is a dependency of our default universe. https://www.internalfb.com/code/fbsource/[d00d16b2dbe75afdd99af7d8343e42258d4f73be]/third-party/rust/vendor/num-bigint-dig-0.8.2/Cargo.toml?lines=56-58 Reviewed By: cjlongoria Differential Revision: D77739243 fbshipit-source-id: 6d913e83ed0947be489b39dcf40738e4381b8783
1 parent 380e11b commit 750c058

File tree

3 files changed

+3
-3
lines changed

3 files changed

+3
-3
lines changed

hyperactor/Cargo.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ hostname = "0.3"
3131
hyperactor_macros = { version = "0.0.0", path = "../hyperactor_macros" }
3232
hyperactor_telemetry = { version = "0.0.0", path = "../hyperactor_telemetry" }
3333
inventory = "0.3.8"
34-
lazy_static = { version = "1.5", features = ["spin_no_std"], default-features = false }
34+
lazy_static = "1.5"
3535
ndslice = { version = "0.0.0", path = "../ndslice" }
3636
nix = { version = "0.29.0", features = ["dir", "event", "hostname", "inotify", "ioctl", "mman", "mount", "net", "poll", "ptrace", "reboot", "resource", "sched", "signal", "term", "time", "user", "zerocopy"] }
3737
opentelemetry = "0.29"

hyperactor_telemetry/Cargo.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ anyhow = "1.0.98"
1212
dashmap = { version = "5.5.3", features = ["rayon", "serde"] }
1313
fbinit = { version = "0.2.0", git = "https://github.com/facebookexperimental/rust-shed.git", branch = "main", optional = true }
1414
hdrhistogram = "7.5"
15-
lazy_static = { version = "1.5", features = ["spin_no_std"], default-features = false }
15+
lazy_static = "1.5"
1616
opentelemetry = "0.29"
1717
opentelemetry_sdk = { version = "0.29.0", features = ["rt-tokio"] }
1818
rand = { version = "0.8", features = ["small_rng"] }

monarch_simulator/Cargo.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ dashmap = { version = "5.5.3", features = ["rayon", "serde"] }
2020
futures = { version = "0.3.30", features = ["async-await", "compat"] }
2121
hyperactor = { version = "0.0.0", path = "../hyperactor" }
2222
hyperactor_multiprocess = { version = "0.0.0", path = "../hyperactor_multiprocess" }
23-
lazy_static = { version = "1.5", features = ["spin_no_std"], default-features = false }
23+
lazy_static = "1.5"
2424
monarch_messages = { version = "0.0.0", path = "../monarch_messages" }
2525
monarch_tensor_worker = { version = "0.0.0", path = "../monarch_tensor_worker" }
2626
monarch_types = { version = "0.0.0", path = "../monarch_types" }

0 commit comments

Comments
 (0)