Skip to content

Commit 3eec37f

Browse files
James Sunfacebook-github-bot
authored andcommitted
(7/n) delete hyperactor_state (#520)
Summary: Pull Request resolved: #520 1. consolidate logging utils into logging.rs 2. delete the state actor as there is nothing there now. We can bring it back easily once we start to build it seriously. Reviewed By: shayne-fletcher Differential Revision: D78201006 fbshipit-source-id: 2c79d3128e6d099851b8a055c167b3443b25e570
1 parent 91f24b1 commit 3eec37f

File tree

9 files changed

+391
-1243
lines changed

9 files changed

+391
-1243
lines changed

hyperactor_mesh/Cargo.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,9 +33,9 @@ dashmap = { version = "5.5.3", features = ["rayon", "serde"] }
3333
enum-as-inner = "0.6.0"
3434
erased-serde = "0.3.27"
3535
futures = { version = "0.3.30", features = ["async-await", "compat"] }
36+
hostname = "0.3"
3637
hyperactor = { version = "0.0.0", path = "../hyperactor" }
3738
hyperactor_mesh_macros = { version = "0.0.0", path = "../hyperactor_mesh_macros" }
38-
hyperactor_state = { version = "0.0.0", path = "../hyperactor_state" }
3939
hyperactor_telemetry = { version = "0.0.0", path = "../hyperactor_telemetry" }
4040
libc = "0.2.139"
4141
mockall = "0.13.1"

hyperactor_mesh/src/alloc/process.rs

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -50,6 +50,7 @@ use crate::bootstrap;
5050
use crate::bootstrap::Allocator2Process;
5151
use crate::bootstrap::Process2Allocator;
5252
use crate::bootstrap::Process2AllocatorMessage;
53+
use crate::logging::create_log_writers;
5354
use crate::shortuuid::ShortUuid;
5455

5556
/// The maximum number of log lines to tail keep for managed processes.
@@ -155,10 +156,7 @@ impl Child {
155156
Box::new(io::stderr());
156157

157158
// Use the helper function to create both writers at once
158-
match hyperactor_state::log_writer::create_log_writers(
159-
log_channel,
160-
process.id().unwrap_or(0),
161-
) {
159+
match create_log_writers(log_channel, process.id().unwrap_or(0)) {
162160
Ok((stdout_writer, stderr_writer)) => {
163161
stdout_tee = stdout_writer;
164162
stderr_tee = stderr_writer;

0 commit comments

Comments
 (0)