asyncio: fix default for subprocess_exec (#9561)

Author: JelleZijlstra

stdlib/asyncio/base_events.pyi

@@ -399,7 +399,7 @@ class BaseEventLoop(AbstractEventLoop):
         stdout: int | IO[Any] | None = -1,
         stderr: int | IO[Any] | None = -1,
         universal_newlines: Literal[False] = False,
-        shell: Literal[True] = ...,
+        shell: Literal[False] = False,
         bufsize: Literal[0] = 0,
         encoding: None = None,
         errors: None = None,

stdlib/asyncio/events.pyi

@@ -542,7 +542,7 @@ class AbstractEventLoop:
         stdout: int | IO[Any] | None = -1,
         stderr: int | IO[Any] | None = -1,
         universal_newlines: Literal[False] = ...,
-        shell: Literal[True] = ...,
+        shell: Literal[False] = ...,
         bufsize: Literal[0] = ...,
         encoding: None = ...,
         errors: None = ...,

tests/stubtest_allowlists/py310.txt

@@ -7,6 +7,8 @@ _collections_abc.ItemsView.__reversed__
 _collections_abc.KeysView.__reversed__
 _collections_abc.ValuesView.__reversed__
 _weakref.ProxyType.__reversed__  # Doesn't really exist
+asyncio.BaseEventLoop.subprocess_exec # BaseEventLoop adds several parameters and stubtest fails on the difference if we add them
+asyncio.base_events.BaseEventLoop.subprocess_exec # BaseEventLoop adds several parameters and stubtest fails on the difference if we add them
 asyncio.Future.__init__  # Usually initialized from c object
 asyncio.futures.Future.__init__  # Usually initialized from c object
 builtins.float.__setformat__  # Internal method for CPython test suite

tests/stubtest_allowlists/py311.txt

@@ -101,6 +101,8 @@ types.GenericAlias.__getattr__
 types.GenericAlias.__mro_entries__
 weakref.ProxyType.__reversed__  # Doesn't really exist
 inspect._ParameterKind.description  # Still exists, but stubtest can't see it
+asyncio.BaseEventLoop.subprocess_exec # BaseEventLoop adds several parameters and stubtest fails on the difference if we add them
+asyncio.base_events.BaseEventLoop.subprocess_exec # BaseEventLoop adds several parameters and stubtest fails on the difference if we add them
 
 # C signature is broader than what is actually accepted
 ast.Bytes.__new__

tests/stubtest_allowlists/py38.txt

@@ -11,6 +11,8 @@ ast.Ellipsis.__new__
 ast.NameConstant.__new__
 ast.Num.__new__
 ast.Str.__new__
+asyncio.BaseEventLoop.subprocess_exec # BaseEventLoop adds several parameters and stubtest fails on the difference if we add them
+asyncio.base_events.BaseEventLoop.subprocess_exec # BaseEventLoop adds several parameters and stubtest fails on the difference if we add them
 asyncio.Future.__init__  # Usually initialized from c object
 asyncio.futures.Future.__init__  # Usually initialized from c object
 asyncio.locks._ContextManagerMixin.__enter__  # Always raises; deliberately omitted from the stub

tests/stubtest_allowlists/py39.txt

@@ -13,6 +13,8 @@ ast.Index.__new__
 ast.NameConstant.__new__
 ast.Num.__new__
 ast.Str.__new__
+asyncio.BaseEventLoop.subprocess_exec # BaseEventLoop adds several parameters and stubtest fails on the difference if we add them
+asyncio.base_events.BaseEventLoop.subprocess_exec # BaseEventLoop adds several parameters and stubtest fails on the difference if we add them
 asyncio.Future.__init__  # Usually initialized from c object
 asyncio.futures.Future.__init__  # Usually initialized from c object
 builtins.float.__setformat__  # Internal method for CPython test suite

tests/stubtest_allowlists/py3_common.txt

@@ -34,12 +34,10 @@ argparse.Namespace.__getattr__  # The whole point of this class is its attribute
 asynchat.async_chat.encoding  # Removal planned for 3.12, can add if someone needs this
 asynchat.async_chat.use_encoding  # Removal planned for 3.12, can add if someone needs this
 asynchat.find_prefix_at_end  # Removal planned for 3.12, can add if someone needs this
-asyncio.BaseEventLoop.subprocess_exec # BaseEventLoop adds several parameters and stubtest fails on the difference if we add them
 # Condition functions are exported in __init__
 asyncio.Condition.acquire
 asyncio.Condition.locked
 asyncio.Condition.release
-asyncio.base_events.BaseEventLoop.subprocess_exec # BaseEventLoop adds several parameters and stubtest fails on the difference if we add them
 # Condition functions are exported in __init__
 asyncio.locks.Condition.acquire
 asyncio.locks.Condition.locked