Skip to content

Commit 8d8420b

Browse files
authored
Fix bugs in check_new_syntax.py (#7808)
1 parent bb39bdf commit 8d8420b

File tree

1 file changed

+6
-0
lines changed

1 file changed

+6
-0
lines changed

tests/check_new_syntax.py

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -44,10 +44,12 @@ def visit_Subscript(self, node: ast.Subscript) -> None:
4444
class OldSyntaxFinder(ast.NodeVisitor):
4545
def visit_AnnAssign(self, node: ast.AnnAssign) -> None:
4646
AnnotationUnionFinder().visit(node.annotation)
47+
self.generic_visit(node)
4748

4849
def visit_arg(self, node: ast.arg) -> None:
4950
if node.annotation is not None:
5051
AnnotationUnionFinder().visit(node.annotation)
52+
self.generic_visit(node)
5153

5254
def _visit_function(self, node: ast.FunctionDef | ast.AsyncFunctionDef) -> None:
5355
if node.returns is not None:
@@ -62,10 +64,12 @@ def visit_AsyncFunctionDef(self, node: ast.AsyncFunctionDef) -> None:
6264

6365
def visit_Assign(self, node: ast.Assign) -> None:
6466
NonAnnotationUnionFinder().visit(node.value)
67+
self.generic_visit(node)
6568

6669
def visit_ClassDef(self, node: ast.ClassDef) -> None:
6770
for base in node.bases:
6871
NonAnnotationUnionFinder().visit(base)
72+
self.generic_visit(node)
6973

7074
class ObjectClassdefFinder(ast.NodeVisitor):
7175
def visit_ClassDef(self, node: ast.ClassDef) -> None:
@@ -80,10 +84,12 @@ class TextFinder(ast.NodeVisitor):
8084
def visit_ImportFrom(self, node: ast.ImportFrom) -> None:
8185
if node.module == "typing" and any(thing.name == "Text" for thing in node.names):
8286
errors.append(f"{path}:{node.lineno}: Use `str` instead of `typing.Text` in a Python-3-only stub.")
87+
self.generic_visit(node)
8388

8489
def visit_Attribute(self, node: ast.Attribute) -> None:
8590
if isinstance(node.value, ast.Name) and node.value.id == "typing" and node.attr == "Text":
8691
errors.append(f"{path}:{node.lineno}: Use `str` instead of `typing.Text` in a Python-3-only stub.")
92+
self.generic_visit(node)
8793

8894
class IfFinder(ast.NodeVisitor):
8995
def visit_If(self, node: ast.If) -> None:

0 commit comments

Comments
 (0)