Skip to content

Commit 58a6938

Browse files
skirpichevhugovk
andauthored
Apply suggestions from code review
Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
1 parent 8cdce7a commit 58a6938

File tree

1 file changed

+6
-6
lines changed

1 file changed

+6
-6
lines changed

peps/pep-0791.rst

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@ subsection of the documentation return a float, but the
3838
documentation doesn't say so. In the documentation for the proposed ``imath`` module the sentence "All
3939
return values are integers." would be accurate. In a similar way we
4040
can simplify the description of the accepted arguments for functions in both the
41-
new module and the :external+py3.14:mod:`math`.
41+
new module and in :external+py3.14:mod:`math`.
4242
Which content, as in beginning, will be again related to work with "just
4343
numbers" --- that for most people with basic education means some model of real
4444
numbers).
@@ -55,7 +55,7 @@ Currently the :external+py3.14:mod:`math` module code in the CPython is around
5555
comparable with the :external+py3.14:mod:`cmath` (1340LOC), which is *not* a
5656
simple wrapper to the ``libm``, as most functions in the
5757
:external+py3.14:mod:`math` module.
58-
And this situation tends to be worse. When the module split `was first
58+
And this situation tends to get worse. When the module split `was first
5959
proposed
6060
<https://mail.python.org/archives/list/python-ideas@python.org/thread/YYJ5YJBJNCVXQWK5K3WSVNMPUSV56LOR/>`_,
6161
there were only two integer-related functions:
@@ -73,9 +73,9 @@ Sure, we can be much more vague in the module preamble (i.e. roughly say
7373
that "the :external+py3.14:mod:`math` module contains some mathematical
7474
functions") and we can accurately describe input/output for each function.
7575

76-
But the major issue is that current module mix different, almost non-interlaced
76+
But the major issue is that the current module mixes different, almost non-interlaced
7777
application domains. Adding more documentation will just highlight this and
78-
make the issue worse for end users (more stuff to read/skip). And it will not
78+
make the issue worse for end users (more text to read/skip). And it will not
7979
fix issue with discoverability (to know in which module to find a function, and
8080
that it can be found at all, you need to look at all the functions in the
8181
module), nor with tab-completion.
@@ -158,8 +158,8 @@ interval math or numerical integration.
158158
Other proposed names include ``ntheory`` (like SymPy's submodule),
159159
``integermath`` and ``imaths``.
160160

161-
As a variant, new module can be added as a submodule of the
162-
:external+py3.14:mod:`math`. The main module itself will preserve "catch-all"
161+
As a variant, the new module can be added as a submodule of the
162+
:external+py3.14:mod:`math`. The main module itself will preserve a "catch-all"
163163
role for mathematics in the stdlib.
164164

165165

0 commit comments

Comments
 (0)