Skip to content

Commit a7a2ff9

Browse files
jakkdlwebknjaz
andauthored
Apply suggestions from code review
Co-authored-by: 🇺🇦 Sviatoslav Sydorenko (Святослав Сидоренко) <wk.cvs.github@sydorenko.org.ua>
1 parent 2fd7fcf commit a7a2ff9

File tree

2 files changed

+5
-3
lines changed

2 files changed

+5
-3
lines changed

.codecov.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ codecov:
66
notify:
77
# This number needs to be changed whenever the number of runs in CI is changed.
88
# Another option is codecov-cli: https://github.com/codecov/codecov-cli#send-notifications
9-
after_n_builds: 78
9+
after_n_builds: 27
1010
wait_for_ci: false
1111
notify_error: true # if uploads fail, replace cov comment with a comment with errors.
1212
require_ci_to_pass: false

.github/workflows/ci.yml

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -134,7 +134,9 @@ jobs:
134134
env:
135135
CHECK_FORMATTING: '${{ matrix.check_formatting }}'
136136
NO_TEST_REQUIREMENTS: '${{ matrix.no_test_requirements }}'
137-
- if: ${{ always() && matrix.check_formatting != '1' }}
137+
- if: >-
138+
always()
139+
&& matrix.check_formatting != '1'
138140
uses: codecov/codecov-action@v3
139141
with:
140142
directory: empty
@@ -198,7 +200,7 @@ jobs:
198200
run: source .venv/bin/activate && ./ci.sh
199201
- name: Get Python version for codecov flag
200202
id: get-version
201-
run: echo "version=$(python -V | cut -d' ' -f2 | cut -d'.' -f1,2)" > $GITHUB_OUTPUT
203+
run: echo "version=$(python -V | cut -d' ' -f2 | cut -d'.' -f1,2)" >> "${GITHUB_OUTPUT}"
202204
- if: always()
203205
uses: codecov/codecov-action@v3
204206
with:

0 commit comments

Comments
 (0)