Skip to content

Commit 919cc8b

Browse files
committed
The CI runners have dev.tty.legacy_tiocsti set to 0
This means that we cannot test our usage of `TIOCSTI`. This ctrl+c support was dead on arrival!
1 parent b71a1b8 commit 919cc8b

File tree

1 file changed

+4
-1
lines changed

1 file changed

+4
-1
lines changed

src/trio/_tests/test_repl.py

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -244,8 +244,11 @@ def test_main_entrypoint() -> None:
244244
assert repl.returncode == 0
245245

246246

247-
@pytest.mark.skipif(sys.platform == "win32", reason="uses PTYs")
247+
# TODO: skip this based on sysctls? Or Linux version?
248+
@pytest.mark.skipif(True, reason="the ioctl we use is disabled in CI")
248249
def test_ki_newline_injection() -> None:
250+
# TODO: we want to remove this functionality, eg by using vendored
251+
# pyrepls.
249252
assert sys.platform != "win32"
250253

251254
import pty

0 commit comments

Comments
 (0)