Respond to review feedback

Author: njsmith

docs/source/tutorial/echo-server.py

@@ -21,7 +21,6 @@ async def echo_server(server_stream):
             print("echo_server {}: received data {!r}".format(ident, data))
             await server_stream.send_all(data)
         print("echo_server {}: connection closed".format(ident))
-        return
     # FIXME: add discussion of MultiErrors to the tutorial, and use
     # MultiError.catch here. (Not important in this case, but important if the
     # server code uses nurseries internally.)

newsfragments/959.feature.rst

@@ -1,8 +1,10 @@
 If you have a `~trio.abc.ReceiveStream` object, you can now use
 ``async for data in stream: ...`` instead of calling
-`~trio.abc.ReceiveStream.receive_some` repeatedly. And the best part
-is, it automatically checks for EOF for you, so you don't have to.
-Also, you no longer have to choose a magic buffer size value before
-calling `~trio.abc.ReceiveStream.receive_some`; you can now call
-``await stream.receive_some()`` and the stream will automatically pick
-a reasonable value for you.
+`~trio.abc.ReceiveStream.receive_some`. Each iteration gives an
+arbitrary sized chunk of bytes. And the best part is, the loop
+automatically exits when you reach EOF, so you don't have to check for
+it yourself anymore. Relatedly, you no longer need to pick a magic
+buffer size value before calling
+`~trio.abc.ReceiveStream.receive_some`; you can ``await
+stream.receive_some()`` with no arguments, and the stream will
+automatically pick a reasonable size for you.

trio/_abc.py

@@ -379,7 +379,9 @@ class ReceiveStream(AsyncResource):
     :class:`ReceiveChannel`.
 
     `ReceiveStream` objects can be used in ``async for`` loops. Each iteration
-    will produce an arbitrary size
+    will produce an arbitrary sized chunk of bytes, like calling
+    `receive_some` with no arguments. Every chunk will contain at least one
+    byte, and the loop automatically exits when reaching end-of-file.
 
     """
     __slots__ = ()

trio/tests/test_ssl.py

@@ -1235,7 +1235,7 @@ async def setup(**kwargs):
     ################
 
     # Test https_compatible
-    _, ssl_listener, ssl_client = await setup(https_compatible=True,)
+    _, ssl_listener, ssl_client = await setup(https_compatible=True)
 
     ssl_server = await ssl_listener.accept()