fixed failing test

Author: eadwinCode

ellar/common/constants.py

@@ -128,7 +128,7 @@ def __deepcopy__(
 
 NOT_SET: Any = NOT_SET_TYPE()
 
-
+ELLAR_LOG_FMT_STRING = "%(levelname)s: [%(name)s] %(message)s"
 DEFAULT_LOGGING = {
     "version": 1,
     "disable_existing_loggers": False,
@@ -142,6 +142,10 @@ def __deepcopy__(
             "()": "uvicorn.logging.AccessFormatter",
             "fmt": '%(levelprefix)s %(client_addr)s - "%(request_line)s" %(status_code)s',
         },
+        "ellar-formatter": {
+            "()": "logging.Formatter",
+            "fmt": ELLAR_LOG_FMT_STRING,
+        },
     },
     "handlers": {
         "default": {
@@ -154,6 +158,11 @@ def __deepcopy__(
             "class": "logging.StreamHandler",
             "stream": "ext://sys.stdout",
         },
+        "ellar-default": {
+            "formatter": "ellar-formatter",
+            "class": "logging.StreamHandler",
+            "stream": "ext://sys.stdout",
+        },
         "console": {
             "class": "logging.StreamHandler",
         },
@@ -163,14 +172,14 @@ def __deepcopy__(
         "uvicorn.error": {"level": "INFO"},
         "uvicorn.access": {"handlers": ["access"], "level": "INFO", "propagate": False},
         "ellar": {
-            "handlers": ["default"],
+            "handlers": ["ellar-default"],
             "level": "INFO",
             "propagate": False,
         },
         "ellar.request": {
-            "handlers": ["default"],
+            "handlers": ["ellar-default"],
             "level": "INFO",
-            "propagate": True,
+            "propagate": False,
         },
     },
 }

ellar/common/params/resolvers/parameter.py

@@ -153,7 +153,7 @@ async def get_request_body(self, ctx: IExecutionContext) -> t.Any:
                     body_bytes = json_body
             return body_bytes
         except json.JSONDecodeError as e:
-            request_logger.error("JSONDecodeError: ", exc_info=e)
+            request_logger.error("JSONDecodeError: ", exc_info=True)
             raise RequestValidationError([ErrorWrapper(e, ("body", e.pos))]) from e
         except Exception as e:  # pragma: no cover
             request_logger.error("Unable to parse the body: ", exc_info=e)
@@ -191,7 +191,7 @@ async def get_request_body(self, ctx: IExecutionContext) -> t.Any:
             body_bytes = await request.form()
             return body_bytes
         except Exception as e:
-            request_logger.error("Unable to parse the body: ", exc_info=e)
+            request_logger.error("Unable to parse the body: ", exc_info=True)
             raise HTTPException(
                 status_code=400, detail="There was an error parsing the body"
             ) from e

ellar/core/main.py

@@ -5,7 +5,7 @@
 from ellar.auth import IIdentitySchemes
 from ellar.auth.handlers import AuthenticationHandlerType
 from ellar.common.compatible import cached_property
-from ellar.common.constants import DEFAULT_LOGGING, LOG_LEVELS
+from ellar.common.constants import LOG_LEVELS
 from ellar.common.datastructures import State, URLPath
 from ellar.common.interfaces import IExceptionHandler, IExceptionMiddlewareService
 from ellar.common.logger import logger
@@ -90,12 +90,20 @@ def _config_logging(self) -> None:
             if self.config.LOG_LEVEL
             else LOG_LEVELS.info.value
         )
-
-        logging_config = self.config.LOGGING_CONFIG or DEFAULT_LOGGING
-        logging.config.dictConfig(logging_config)
-
-        logging.getLogger("ellar").setLevel(log_level)
-        logging.getLogger("ellar.request").setLevel(log_level)
+        logger_ = logging.getLogger("ellar")
+        if not logger_.handlers:
+            formatter = logging.Formatter("%(levelname)s: [%(name)s] %(message)s")
+            stream_handler = logging.StreamHandler()
+            # file_handler = logging.FileHandler("my_app.log")
+            # file_handler.setFormatter(formatter)
+            # logger_.addHandler(file_handler)
+            stream_handler.setFormatter(formatter)
+            logger_.addHandler(stream_handler)
+
+            logger_.setLevel(log_level)
+        else:
+            logging.getLogger("ellar").setLevel(log_level)
+            logging.getLogger("ellar.request").setLevel(log_level)
 
         logger.info(f"APP SETTINGS MODULE: {self.config.config_module}")
         logger.debug("ELLAR LOGGER CONFIGURED")