Skip to content

Commit 6cdd4a5

Browse files
committed
removed unneccessary exceptions
1 parent 7f163e9 commit 6cdd4a5

File tree

1 file changed

+9
-5
lines changed

1 file changed

+9
-5
lines changed

ellar/core/main.py

Lines changed: 9 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,13 @@
2020
RequestVersioningMiddleware,
2121
TrustedHostMiddleware,
2222
)
23-
from ellar.core.modules import DynamicModule, ModuleBase, ModuleSetup, ModuleTemplateRef
23+
from ellar.core.modules import (
24+
DynamicModule,
25+
ModuleBase,
26+
ModuleRefBase,
27+
ModuleSetup,
28+
ModuleTemplateRef,
29+
)
2430
from ellar.core.routing import ApplicationRouter
2531
from ellar.core.templating import AppTemplating, Environment
2632
from ellar.core.versioning import VERSIONING, BaseAPIVersioning
@@ -142,13 +148,11 @@ def install_module(
142148
if module_ref:
143149
return module_ref.get_module_instance()
144150

145-
module_ref = module_config.get_module_ref( # type: ignore
151+
module_ref = module_config.get_module_ref( # type: ignore[assignment]
146152
config=self.config,
147153
container=self.injector.container,
148154
)
149-
if not module_ref:
150-
raise Exception(f"Invalid Module Configuration for {module_config.module}")
151-
155+
assert isinstance(module_ref, ModuleRefBase)
152156
self.injector.add_module(module_ref)
153157

154158
module_ref.run_module_register_services()

0 commit comments

Comments
 (0)