Skip to content

Commit 61163d5

Browse files
committed
fixed failing test
1 parent d8b2985 commit 61163d5

File tree

2 files changed

+7
-27
lines changed

2 files changed

+7
-27
lines changed

tests/test_di/test_providers.py

Lines changed: 7 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,5 @@
11
import pytest
2-
from injector import (
3-
CircularDependency,
4-
UnsatisfiedRequirement,
5-
is_decorated_with_inject,
6-
)
2+
from injector import CircularDependency, is_decorated_with_inject
73

84
from ellar.di import (
95
EllarInjector,
@@ -99,25 +95,12 @@ def test_provider_advance_use_case():
9995
assert isinstance(db_context, AnyDBContext)
10096
assert repository.context == db_context # service registered as singleton
10197

102-
with pytest.raises(UnsatisfiedRequirement):
103-
injector.get(AnyDBContext)
104-
105-
with pytest.raises(UnsatisfiedRequirement):
106-
injector.get(FooDBCatsRepository)
107-
108-
providers_advance.append(ProviderConfig(AnyDBContext))
109-
providers_advance.append(ProviderConfig(FooDBCatsRepository))
110-
111-
injector = EllarInjector(auto_bind=False)
112-
113-
for provider in providers_advance:
114-
provider.register(injector.container)
115-
116-
assert injector.get(AnyDBContext)
117-
assert injector.get(FooDBCatsRepository)
118-
119-
assert isinstance(injector.get(IRepository), FooDBCatsRepository)
120-
assert isinstance(injector.get(IDBContext), AnyDBContext)
98+
assert isinstance(
99+
injector.get(FooDBCatsRepository), FooDBCatsRepository
100+
) # only possible because they are decorated with injectable
101+
assert isinstance(
102+
injector.get(AnyDBContext), AnyDBContext
103+
) # only possible because they are decorated with injectable
121104

122105

123106
def test_module_provider_works():

tests/test_modules/test_module_ref.py

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -89,9 +89,6 @@ def test_module_ref_registers_module_type():
8989
config = Config()
9090
container = EllarInjector(auto_bind=False).container
9191

92-
with pytest.raises(Exception):
93-
container.injector.get(ModuleBaseExample)
94-
9592
create_module_ref_factor(ModuleBaseExample, config=config, container=container)
9693
create_module_ref_factor(ModuleProviderTest, config=config, container=container)
9794

0 commit comments

Comments
 (0)