improved test-coverage

Author: eadwinCode

ellar/common/routing/schema.py

@@ -3,12 +3,10 @@
 from ellar.common.constants import ROUTE_METHODS
 from ellar.common.interfaces import IResponseModel
 from ellar.common.responses.models import EmptyAPIResponseModel, create_response_model
+from ellar.common.routing.websocket import WebSocketExtraHandler
 from ellar.common.serializer import BaseSerializer
 from pydantic import BaseModel, Field, PrivateAttr, root_validator, validator
 
-if t.TYPE_CHECKING:  # pragma: no cover
-    from ellar.common.routing.websocket import WebSocketExtraHandler
-
 
 class TResponseModel:
     @classmethod

tests/test_routing/test_module_mount.py

@@ -0,0 +1,13 @@
+from ellar.common.routing import ModuleMount
+
+
+class ControlType:
+    pass
+
+
+def test_module_mount_default_handler(test_client_factory):
+    mount = ModuleMount("/", ControlType, routes=[])
+    client = test_client_factory(mount.handle)
+    res = client.get("/")
+    assert res.status_code == 404
+    assert res.text == "Not Found"

tests/test_websocket_handler.py

@@ -5,6 +5,7 @@
     ImproperConfiguration,
     WebSocketRequestValidationError,
 )
+from ellar.common.routing.websocket import WebSocketExtraHandler
 from ellar.reflect import reflect
 from ellar.testing import Test
 from starlette.websockets import WebSocket, WebSocketState
@@ -316,3 +317,25 @@ def test_add_websocket_handler_raise_exception_for_wrong_handler_name():
         str(ex.value)
         == "Invalid Handler Name. Handler Name must be in ['encoding', 'on_receive', 'on_connect', 'on_disconnect']"
     )
+    websocket_operation.add_websocket_handler(
+        handler_name="on_receive", handler=websocket_with_handler_connect
+    )
+
+
+def test_websocket_handler_fails_for_invalid_handlers():
+    a_type = type("AType", (), {})
+    with pytest.raises(ValueError):
+
+        @ws_route(extra_handler_type=a_type)
+        def invalid_ws_route():
+            pass
+
+    with pytest.raises(ValueError):
+
+        @ws_route(extra_handler_type=a_type())
+        def invalid_ws_route_case_2():
+            pass
+
+    @ws_route(extra_handler_type=WebSocketExtraHandler)
+    def valid_ws_route():
+        pass