Skip to content

save a request in the github info cog when fetching pulls #1697

@onerandomusername

Description

@onerandomusername

Description

# If the 'issues' key is not contained in the API response and there is no error code, then
# we know that a PR has been requested and a call to the pulls API endpoint is necessary
# to get the desired information for the PR.

This data is provided in the issue body under the pull_request key. We don't need to fetch a second time.

Reasoning

This will halve the requests used to look up a pull request, which stacks when looking up 2 or 3 pull requests at a time.

Proposed Implementation

Additional Details

Would you like to implement this yourself?

  • I'd like to implement this feature myself
  • Anyone can implement this feature

Metadata

Metadata

Labels

status: approvedThe issue has received a core developer's approvaltype: featureRelating to the functionality of the application.

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions