Skip to content

Commit b911a0b

Browse files
committed
Merge branch 'master' into 3.0.0 - Use add_subparsers() 'required' keyword argument
2 parents 29c8d11 + 9fc5683 commit b911a0b

File tree

5 files changed

+6
-12
lines changed

5 files changed

+6
-12
lines changed

cmd2/cmd2.py

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3278,8 +3278,7 @@ def _cmdloop(self) -> None:
32783278
def _build_alias_parser() -> Cmd2ArgumentParser:
32793279
alias_description = "Manage aliases."
32803280
alias_parser = argparse_custom.DEFAULT_ARGUMENT_PARSER(description=alias_description)
3281-
alias_subparsers = alias_parser.add_subparsers(dest='subcommand', metavar='SUBCOMMAND')
3282-
alias_subparsers.required = True
3281+
alias_parser.add_subparsers(dest='subcommand', metavar='SUBCOMMAND', required=True)
32833282

32843283
return alias_parser
32853284

tests/test_argparse.py

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -248,8 +248,7 @@ def test_preservelist(argparse_app):
248248

249249
def _build_has_subcmd_parser() -> cmd2.Cmd2ArgumentParser:
250250
has_subcmds_parser = cmd2.Cmd2ArgumentParser(description="Tests as_subcmd_to decorator")
251-
has_subcmds_subparsers = has_subcmds_parser.add_subparsers(dest='subcommand', metavar='SUBCOMMAND')
252-
has_subcmds_subparsers.required = True
251+
has_subcmds_parser.add_subparsers(dest='subcommand', metavar='SUBCOMMAND', required=True)
253252
return has_subcmds_parser
254253

255254

@@ -271,8 +270,7 @@ def base_helpless(self, args):
271270

272271
# create the top-level parser for the base command
273272
base_parser = cmd2.Cmd2ArgumentParser()
274-
base_subparsers = base_parser.add_subparsers(dest='subcommand', metavar='SUBCOMMAND')
275-
base_subparsers.required = True
273+
base_subparsers = base_parser.add_subparsers(dest='subcommand', metavar='SUBCOMMAND', required=True)
276274

277275
# create the parser for the "foo" subcommand
278276
parser_foo = base_subparsers.add_parser('foo', help='foo help')

tests/test_argparse_completer.py

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1249,8 +1249,7 @@ def do_custom_completer(self, args: argparse.Namespace) -> None:
12491249

12501250
# Test as_subcommand_to decorator with custom completer
12511251
top_parser = Cmd2ArgumentParser(description="Top Command")
1252-
top_subparsers = top_parser.add_subparsers(dest='subcommand', metavar='SUBCOMMAND')
1253-
top_subparsers.required = True
1252+
top_parser.add_subparsers(dest='subcommand', metavar='SUBCOMMAND', required=True)
12541253

12551254
@with_argparser(top_parser)
12561255
def do_top(self, args: argparse.Namespace) -> None:

tests_isolated/test_commandset/test_argparse_subcommands.py

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -35,8 +35,7 @@ def base_helpless(self, args):
3535

3636
# create the top-level parser for the base command
3737
base_parser = cmd2.Cmd2ArgumentParser()
38-
base_subparsers = base_parser.add_subparsers(dest='subcommand', metavar='SUBCOMMAND')
39-
base_subparsers.required = True
38+
base_subparsers = base_parser.add_subparsers(dest='subcommand', metavar='SUBCOMMAND', required=True)
4039

4140
# create the parser for the "foo" subcommand
4241
parser_foo = base_subparsers.add_parser('foo', help='foo help')

tests_isolated/test_commandset/test_commandset.py

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -93,8 +93,7 @@ def do_elderberry(self, ns: argparse.Namespace):
9393
# Test that CommandSet with as_subcommand_to decorator successfully loads
9494
# during `cmd2.Cmd.__init__()`.
9595
main_parser = cmd2.Cmd2ArgumentParser(description="Main Command")
96-
main_subparsers = main_parser.add_subparsers(dest='subcommand', metavar='SUBCOMMAND')
97-
main_subparsers.required = True
96+
main_parser.add_subparsers(dest='subcommand', metavar='SUBCOMMAND', required=True)
9897

9998
@cmd2.with_category('Alone')
10099
@cmd2.with_argparser(main_parser)

0 commit comments

Comments
 (0)