Skip to content

Commit 74b21c8

Browse files
committed
Recombine test and skip both parts on Windows
1 parent 9184b5f commit 74b21c8

File tree

1 file changed

+2
-4
lines changed

1 file changed

+2
-4
lines changed

tests/test_cmd2.py

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1793,14 +1793,12 @@ def test_commandresult_falsy(commandresult_app):
17931793
assert commandresult_app.last_result == cmd2.CommandResult('', arg)
17941794

17951795

1796-
@pytest.mark.skipif(sys.platform.startswith('win'), reason="Test is unreliable on GitHub Actions Windows runners")
1797-
def test_is_text_file_bad_no_exist(base_app):
1796+
@pytest.mark.skipif(sys.platform.startswith('win'), reason="Test is problematic on GitHub Actions Windows runners")
1797+
def test_is_text_file_bad_input(base_app):
17981798
# Test with a non-existent file
17991799
with pytest.raises(FileNotFoundError):
18001800
utils.is_text_file('does_not_exist.txt')
18011801

1802-
1803-
def test_is_text_file_bad_is_dir(base_app):
18041802
# Test with a directory
18051803
with pytest.raises(IsADirectoryError):
18061804
utils.is_text_file('.')

0 commit comments

Comments
 (0)