chore: fix some warnings and fix validator build

Author: Riateche

Cargo.lock

@@ -1,6 +1,7 @@
 //! The `validator` module hosts all the validator microservices.
 
 pub use solana_perf::report_target_features;
+use solana_runtime::bank::pyth_accumulator;
 use {
     crate::{
         accounts_hash_verifier::AccountsHashVerifier,
@@ -1521,15 +1522,12 @@ fn load_blockstore(
         }
     }
 
-    {
-        let bank = bank_forks.write().unwrap().working_bank();
-        for (key_name, pk_res) in bank.get_accumulator_keys() {
-            match pk_res {
-                Ok(pk) => info!("Accumulator {}: {}", key_name, pk),
-                Err(err) => {
-                    error!("Failed to get Accumulator {}: {:?}", key_name, err);
-                    std::process::abort();
-                }
+    for (key_name, pk_res) in pyth_accumulator::get_accumulator_keys() {
+        match pk_res {
+            Ok(pk) => info!("Accumulator {}: {}", key_name, pk),
+            Err(err) => {
+                error!("Failed to get Accumulator {}: {:?}", key_name, err);
+                std::process::abort();
             }
         }
     }

core/src/validator.rs

@@ -4323,11 +4323,13 @@ pub fn make_chaining_slot_entries(
 }
 
 #[cfg(not(unix))]
+#[allow(dead_code)] // No longer called.
 fn adjust_ulimit_nofile(_enforce_ulimit_nofile: bool) -> Result<()> {
     Ok(())
 }
 
 #[cfg(unix)]
+#[allow(dead_code)] // No longer called.
 fn adjust_ulimit_nofile(enforce_ulimit_nofile: bool) -> Result<()> {
     // Rocks DB likes to have many open files.  The default open file descriptor limit is
     // usually not enough

ledger/src/blockstore.rs

@@ -158,7 +158,6 @@ use {
         ops::{Deref, RangeInclusive},
         path::PathBuf,
         rc::Rc,
-        str::FromStr,
         sync::{
             atomic::{
                 AtomicBool, AtomicI64, AtomicU64, AtomicUsize,
@@ -199,7 +198,7 @@ mod builtin_programs;
 mod sysvar_cache;
 mod transaction_account_state_info;
 
-mod pyth_accumulator;
+pub mod pyth_accumulator;
 
 pub const SECONDS_PER_YEAR: f64 = 365.25 * 24.0 * 60.0 * 60.0;
 

runtime/src/bank.rs

@@ -20,7 +20,7 @@ use {
 pub const ACCUMULATOR_RING_SIZE: u32 = 10_000;
 
 #[derive(Debug, thiserror::Error)]
-pub enum AccumulatorUpdateV2Error {
+pub enum AccumulatorUpdateErrorV2 {
     #[error("no oracle pubkey")]
     NoOraclePubkey,
     #[error("get_program_accounts failed to return accounts: {0}")]
@@ -282,13 +282,10 @@ fn post_accumulator_attestation(
     >,
     ring_index: u32,
 ) -> std::result::Result<(), AccumulatorUpdateErrorV1> {
-    use {
-        pythnet_sdk::{
-            pythnet,
-            wormhole::{AccumulatorSequenceTracker, MessageData, PostedMessageUnreliableData},
-            ACCUMULATOR_EMITTER_ADDRESS,
-        },
-        solana_sdk::borsh::try_from_slice_unchecked,
+    use pythnet_sdk::{
+        pythnet,
+        wormhole::{AccumulatorSequenceTracker, MessageData, PostedMessageUnreliableData},
+        ACCUMULATOR_EMITTER_ADDRESS,
     };
 
     let accumulator_sequence_addr = env_pubkey_or(
@@ -392,14 +389,14 @@ fn post_accumulator_attestation(
     Ok(())
 }
 
-pub fn update_v2(bank: &Bank) -> std::result::Result<(), AccumulatorUpdateV2Error> {
+pub fn update_v2(bank: &Bank) -> std::result::Result<(), AccumulatorUpdateErrorV2> {
     // 1. Find Oracle
-    let oracle_pubkey = ORACLE_PUBKEY.ok_or(AccumulatorUpdateV2Error::NoOraclePubkey)?;
+    let oracle_pubkey = ORACLE_PUBKEY.ok_or(AccumulatorUpdateErrorV2::NoOraclePubkey)?;
 
     // 2. Find Oracle Accounts
     let accounts = bank
         .get_program_accounts(&oracle_pubkey, &ScanConfig::new(true))
-        .map_err(AccumulatorUpdateV2Error::GetProgramAccounts)?;
+        .map_err(AccumulatorUpdateErrorV2::GetProgramAccounts)?;
 
     // 3. Filter for Price Accounts
     let accounts = accounts.iter().filter(|(_, account)| true);