refactor: revert on version and getRoundData

Author: MerlinEgalite

src/adapters/WstEthChainlinkAdapter.sol

@@ -14,7 +14,6 @@ import {ErrorsLib} from "../libraries/ErrorsLib.sol";
 contract WstEthChainlinkAdapter is AggregatorV3Interface {
     uint8 public constant decimals = uint8(18);
     string public constant description = "wstETH/ETH exchange rate";
-    uint256 public constant version = 1;
 
     IStEth public immutable ST_ETH;
 
@@ -23,8 +22,14 @@ contract WstEthChainlinkAdapter is AggregatorV3Interface {
         ST_ETH = IStEth(stEth);
     }
 
-    function getRoundData(uint80) external view returns (uint80, int256, uint256, uint256, uint80) {
-        return latestRoundData();
+    /// @notice Reverts as no Chainlink aggregator is used.
+    function version() external pure override returns (uint256) {
+        revert();
+    }
+
+    /// @notice Reverts as it's not necessary for the ChainlinkOracle contract.
+    function getRoundData(uint80) external pure returns (uint80, int256, uint256, uint256, uint80) {
+        revert();
     }
 
     function latestRoundData() public view returns (uint80, int256, uint256, uint256, uint80) {

test/WstEthChainlinkAdapterTest.sol

@@ -28,18 +28,6 @@ contract WstEthChainlinkAdapterTest is Test {
         oracle.latestRoundData();
     }
 
-    function testGetRoundDataOverflow(uint256 ethByShares) public {
-        ethByShares = bound(ethByShares, uint256(type(int256).max) + 1, type(uint256).max);
-
-        vm.mockCall(
-            address(ST_ETH),
-            abi.encodeWithSelector(ST_ETH.getPooledEthByShares.selector, 10 ** 18),
-            abi.encode(ethByShares)
-        );
-        vm.expectRevert(bytes(ErrorsLib.OVERFLOW));
-        oracle.getRoundData(1);
-    }
-
     function testDecimals() public {
         assertEq(oracle.decimals(), uint8(18));
     }
@@ -49,24 +37,20 @@ contract WstEthChainlinkAdapterTest is Test {
         new WstEthChainlinkAdapter(address(0));
     }
 
-    function testConfig() public {
+    function testDescription() public {
         assertEq(oracle.description(), "wstETH/ETH exchange rate");
-        assertEq(oracle.version(), 1);
     }
+    function testReverts() public {
+        vm.expectRevert();
+        oracle.version();
 
-    function testLatestRoundData() public {
-        (uint80 roundId, int256 answer, uint256 startedAt, uint256 updatedAt, uint80 answeredInRound) =
-            oracle.latestRoundData();
-        assertEq(roundId, 0);
-        assertEq(uint256(answer), ST_ETH.getPooledEthByShares(10 ** 18));
-        assertEq(startedAt, 0);
-        assertEq(updatedAt, 0);
-        assertEq(answeredInRound, 0);
+        vm.expectRevert();
+        oracle.getRoundData(0);
     }
 
-    function testGetRoundData() public {
+    function testLatestRoundData() public {
         (uint80 roundId, int256 answer, uint256 startedAt, uint256 updatedAt, uint80 answeredInRound) =
-            oracle.getRoundData(1);
+            oracle.latestRoundData();
         assertEq(roundId, 0);
         assertEq(uint256(answer), ST_ETH.getPooledEthByShares(10 ** 18));
         assertEq(startedAt, 0);
@@ -87,19 +71,6 @@ contract WstEthChainlinkAdapterTest is Test {
         assertEq(uint256(answer), ethByShares);
     }
 
-    function testGetRoundDataNoOverflow(uint256 ethByShares) public {
-        ethByShares = bound(ethByShares, 0, uint256(type(int256).max));
-
-        vm.mockCall(
-            address(ST_ETH),
-            abi.encodeWithSelector(ST_ETH.getPooledEthByShares.selector, 10 ** 18),
-            abi.encode(ethByShares)
-        );
-
-        (, int256 answer,,,) = oracle.getRoundData(1);
-        assertEq(uint256(answer), ethByShares);
-    }
-
     function testLatestRoundDataBounds() public {
         (, int256 answer,,,) = oracle.latestRoundData();
         assertGe(uint256(answer), 1154690031824824994); // Exchange rate queried at block 19070943