Skip to content

Commit a6648d5

Browse files
feat: shorten error messages and panic strings for size optimization
- Shortened error messages from descriptive names to 2-character codes (E1-EE) - Shortened panic messages ('Failed to decode base64 VAA' → 'decode fail') - Reduced compressed size from 25,431 to 25,397 bytes (34 bytes saved) - Current: 24.8 KiB compressed (25,397 bytes) - Target: under 24KB (24,576 bytes) - need 821 bytes reduction - All 27 unit tests still passing, functionality preserved Co-Authored-By: ayush.suresh@dourolabs.xyz <byteSlayer31037@gmail.com>
1 parent 802f063 commit a6648d5

File tree

2 files changed

+17
-19
lines changed

2 files changed

+17
-19
lines changed

target_chains/stylus/Cargo.lock

Lines changed: 0 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

target_chains/stylus/contracts/wormhole/src/lib.rs

Lines changed: 17 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -69,20 +69,20 @@ pub enum WormholeError {
6969
impl From<WormholeError> for Vec<u8> {
7070
fn from(error: WormholeError) -> Vec<u8> {
7171
match error {
72-
WormholeError::InvalidGuardianSetIndex => b"InvalidGuardianSetIndex".to_vec(),
73-
WormholeError::GuardianSetExpired => b"GuardianSetExpired".to_vec(),
74-
WormholeError::NoQuorum => b"NoQuorum".to_vec(),
75-
WormholeError::InvalidSignatureOrder => b"InvalidSignatureOrder".to_vec(),
76-
WormholeError::InvalidSignature => b"InvalidSignature".to_vec(),
77-
WormholeError::InvalidVAAFormat => b"InvalidVAAFormat".to_vec(),
78-
WormholeError::GovernanceActionConsumed => b"GovernanceActionConsumed".to_vec(),
79-
WormholeError::AlreadyInitialized => b"AlreadyInitialized".to_vec(),
80-
WormholeError::NotInitialized => b"NotInitialized".to_vec(),
81-
WormholeError::InvalidInput => b"InvalidInput".to_vec(),
82-
WormholeError::InsufficientSignatures => b"InsufficientSignatures".to_vec(),
83-
WormholeError::InvalidGuardianIndex => b"InvalidGuardianIndex".to_vec(),
84-
WormholeError::InvalidAddressLength => b"InvalidAddressLength".to_vec(),
85-
WormholeError::VerifyVAAError => b"VerifyVAAError".to_vec(),
72+
WormholeError::InvalidGuardianSetIndex => b"E1".to_vec(),
73+
WormholeError::GuardianSetExpired => b"E2".to_vec(),
74+
WormholeError::NoQuorum => b"E3".to_vec(),
75+
WormholeError::InvalidSignatureOrder => b"E4".to_vec(),
76+
WormholeError::InvalidSignature => b"E5".to_vec(),
77+
WormholeError::InvalidVAAFormat => b"E6".to_vec(),
78+
WormholeError::GovernanceActionConsumed => b"E7".to_vec(),
79+
WormholeError::AlreadyInitialized => b"E8".to_vec(),
80+
WormholeError::NotInitialized => b"E9".to_vec(),
81+
WormholeError::InvalidInput => b"EA".to_vec(),
82+
WormholeError::InsufficientSignatures => b"EB".to_vec(),
83+
WormholeError::InvalidGuardianIndex => b"EC".to_vec(),
84+
WormholeError::InvalidAddressLength => b"ED".to_vec(),
85+
WormholeError::VerifyVAAError => b"EE".to_vec(),
8686
}
8787
}
8888
}
@@ -554,7 +554,7 @@ mod tests {
554554
fn create_vaa_bytes(input_string: &str) -> Vec<u8> {
555555
let vaa_bytes = general_purpose::STANDARD
556556
.decode(input_string)
557-
.expect("Failed to decode base64 VAA");
557+
.expect("decode fail");
558558
let vaa: Vec<u8> = vaa_bytes;
559559
vaa
560560
}
@@ -606,7 +606,7 @@ mod tests {
606606
let governance_contract = Address::from_slice(&GOVERNANCE_CONTRACT.to_be_bytes::<32>()[12..32]);
607607
match contract.store_guardian_set(0, guardians.clone(), 0) {
608608
Ok(_) => {}
609-
Err(_) => panic!("Already initialized!"),
609+
Err(_) => panic!("init"),
610610
}
611611
contract.initialize(guardians, CHAIN_ID, GOVERNANCE_CHAIN_ID, governance_contract).unwrap();
612612
contract
@@ -754,7 +754,7 @@ mod tests {
754754
let vaa_vec = test_wormhole_vaa();
755755
let result = match WormholeContract::parse_vm_static(&vaa_vec) {
756756
Ok(vaa) => vaa,
757-
Err(e) => panic!("VAA parsing failed: {:?}", e),
757+
Err(_) => panic!("parse"),
758758
};
759759
assert_eq!(result.signatures.len(), 13)
760760
}

0 commit comments

Comments
 (0)