call `getfixturevalue` while `pytest_collection_modifyitems` #9689

hfudev · 2022-02-15T08:51:42Z

hfudev
Feb 15, 2022

Hi, here's my code.

# conftest.py
import pytest

@pytest.fixture
def foo(request):
    return getattr(request, 'param', 1)


def pytest_collection_modifyitems(items):
    for item in items:
        # foo = item._request.getfixturevalue('foo')  # if I comment this line, the test would pass
        pass

# test_foo.py
import pytest

def test_1(foo):
    assert foo==1

@pytest.mark.parametrize(
    'foo', [
        2,
    ],
    indirect=True,
)
def test_2(foo):
    assert foo == 2

If I uncomment the line item._request.getfixturevalue('foo'), would throw out error message like this:

======================================= test session starts ========================================
platform linux -- Python 3.10.2, pytest-7.0.1, pluggy-1.0.0
rootdir:<home_dir>/code/test_pytest
collected 2 items                                                                                  
INTERNALERROR> Traceback (most recent call last):
INTERNALERROR>   File <home_dir>/.cache/pypoetry/virtualenvs/test-pytest-aVGM7ipH-py3.10/lib/python3.10/site-packages/_pytest/main.py", line 268, in wrap_session
INTERNALERROR>     session.exitstatus = doit(config, session) or 0
INTERNALERROR>   File <home_dir>/.cache/pypoetry/virtualenvs/test-pytest-aVGM7ipH-py3.10/lib/python3.10/site-packages/_pytest/main.py", line 321, in _main
INTERNALERROR>     config.hook.pytest_collection(session=session)
INTERNALERROR>   File <home_dir>/.cache/pypoetry/virtualenvs/test-pytest-aVGM7ipH-py3.10/lib/python3.10/site-packages/pluggy/_hooks.py", line 265, in __call__
INTERNALERROR>     return self._hookexec(self.name, self.get_hookimpls(), kwargs, firstresult)
INTERNALERROR>   File <home_dir>/.cache/pypoetry/virtualenvs/test-pytest-aVGM7ipH-py3.10/lib/python3.10/site-packages/pluggy/_manager.py", line 80, in _hookexec
INTERNALERROR>     return self._inner_hookexec(hook_name, methods, kwargs, firstresult)
INTERNALERROR>   File <home_dir>/.cache/pypoetry/virtualenvs/test-pytest-aVGM7ipH-py3.10/lib/python3.10/site-packages/pluggy/_callers.py", line 60, in _multicall
INTERNALERROR>     return outcome.get_result()
INTERNALERROR>   File <home_dir>/.cache/pypoetry/virtualenvs/test-pytest-aVGM7ipH-py3.10/lib/python3.10/site-packages/pluggy/_result.py", line 60, in get_result
INTERNALERROR>     raise ex[1].with_traceback(ex[2])
INTERNALERROR>   File <home_dir>/.cache/pypoetry/virtualenvs/test-pytest-aVGM7ipH-py3.10/lib/python3.10/site-packages/pluggy/_callers.py", line 39, in _multicall
INTERNALERROR>     res = hook_impl.function(*args)
INTERNALERROR>   File <home_dir>/.cache/pypoetry/virtualenvs/test-pytest-aVGM7ipH-py3.10/lib/python3.10/site-packages/_pytest/main.py", line 332, in pytest_collection
INTERNALERROR>     session.perform_collect()
INTERNALERROR>   File <home_dir>/.cache/pypoetry/virtualenvs/test-pytest-aVGM7ipH-py3.10/lib/python3.10/site-packages/_pytest/main.py", line 660, in perform_collect
INTERNALERROR>     hook.pytest_collection_modifyitems(
INTERNALERROR>   File <home_dir>/.cache/pypoetry/virtualenvs/test-pytest-aVGM7ipH-py3.10/lib/python3.10/site-packages/pluggy/_hooks.py", line 265, in __call__
INTERNALERROR>     return self._hookexec(self.name, self.get_hookimpls(), kwargs, firstresult)
INTERNALERROR>   File <home_dir>/.cache/pypoetry/virtualenvs/test-pytest-aVGM7ipH-py3.10/lib/python3.10/site-packages/pluggy/_manager.py", line 80, in _hookexec
INTERNALERROR>     return self._inner_hookexec(hook_name, methods, kwargs, firstresult)
INTERNALERROR>   File <home_dir>/.cache/pypoetry/virtualenvs/test-pytest-aVGM7ipH-py3.10/lib/python3.10/site-packages/pluggy/_callers.py", line 60, in _multicall
INTERNALERROR>     return outcome.get_result()
INTERNALERROR>   File <home_dir>/.cache/pypoetry/virtualenvs/test-pytest-aVGM7ipH-py3.10/lib/python3.10/site-packages/pluggy/_result.py", line 60, in get_result
INTERNALERROR>     raise ex[1].with_traceback(ex[2])
INTERNALERROR>   File <home_dir>/.cache/pypoetry/virtualenvs/test-pytest-aVGM7ipH-py3.10/lib/python3.10/site-packages/pluggy/_callers.py", line 39, in _multicall
INTERNALERROR>     res = hook_impl.function(*args)
INTERNALERROR>   File <home_dir>/code/test_pytest/conftest.py", line 10, in pytest_collection_modifyitems
INTERNALERROR>     foo = item._request.getfixturevalue('foo')
INTERNALERROR>   File <home_dir>/.cache/pypoetry/virtualenvs/test-pytest-aVGM7ipH-py3.10/lib/python3.10/site-packages/_pytest/fixtures.py", line 591, in getfixturevalue
INTERNALERROR>     fixturedef = self._get_active_fixturedef(argname)
INTERNALERROR>   File <home_dir>/.cache/pypoetry/virtualenvs/test-pytest-aVGM7ipH-py3.10/lib/python3.10/site-packages/_pytest/fixtures.py", line 610, in _get_active_fixturedef
INTERNALERROR>     self._compute_fixture_value(fixturedef)
INTERNALERROR>   File <home_dir>/.cache/pypoetry/virtualenvs/test-pytest-aVGM7ipH-py3.10/lib/python3.10/site-packages/_pytest/fixtures.py", line 695, in _compute_fixture_value
INTERNALERROR>     self._schedule_finalizers(fixturedef, subrequest)
INTERNALERROR>   File <home_dir>/.cache/pypoetry/virtualenvs/test-pytest-aVGM7ipH-py3.10/lib/python3.10/site-packages/_pytest/fixtures.py", line 701, in _schedule_finalizers
INTERNALERROR>     subrequest.node.addfinalizer(lambda: fixturedef.finish(request=subrequest))
INTERNALERROR>   File <home_dir>/.cache/pypoetry/virtualenvs/test-pytest-aVGM7ipH-py3.10/lib/python3.10/site-packages/_pytest/nodes.py", line 415, in addfinalizer
INTERNALERROR>     self.session._setupstate.addfinalizer(fin, self)
INTERNALERROR>   File <home_dir>/.cache/pypoetry/virtualenvs/test-pytest-aVGM7ipH-py3.10/lib/python3.10/site-packages/_pytest/runner.py", line 510, in addfinalizer
INTERNALERROR>     assert node in self.stack, (node, self.stack)
INTERNALERROR> AssertionError: (<Function test_1>, {})

====================================== no tests ran in 0.00s =======================================

My goal is to re-order the running sequence based on the value of the fixture. Could anyone give me some suggestions? Many thanks!

RonnyPfannschmidt · 2022-02-15T09:06:35Z

RonnyPfannschmidt
Feb 15, 2022
Maintainer

fixtures are not available at collection time - intentionally for now

its a major change to make this possible and currently there are not enough people avaliable and cappable of working on this

12 replies

hfudev Feb 15, 2022
Author

Thanks for your idea. This approach partially solves the issue.

# conftest.py
@pytest.fixture(scope='session')
def app():
    return 1

# test_foo.py
@pytest.mark.parametrize(
    "app",
    [
        1,
        2,
        3,
        4,
    ],
    indirect=True,
)
def test_1(app):
    assert True


@pytest.mark.parametrize(
    "app",
    [
        1,
        4,
    ],
    indirect=True,
)
def test_2(app):
    assert True

The test sequence would be

test_foo.py::test_1[1] PASSED                          [ 16%]
test_foo.py::test_2[1] PASSED                          [ 33%]
test_foo.py::test_1[2] PASSED                          [ 50%]
test_foo.py::test_2[4] PASSED                          [ 66%]
test_foo.py::test_1[3] PASSED                          [ 83%]
test_foo.py::test_1[4] PASSED                          [100%]

RonnyPfannschmidt Feb 16, 2022
Maintainer

@hfudev can you elaborate the other part?

hfudev Feb 17, 2022
Author

@RonnyPfannschmidt well, as the test result, the test sequence is based on the order of the params, not the order of the param values. Correct me if I wrote the session scope fixture wrongly. Thanks!

RonnyPfannschmidt Feb 17, 2022
Maintainer

It should be based on the values, if it isn't, I would consider it a bug

RonnyPfannschmidt Feb 19, 2022
Maintainer

@hfudev i jsut took note that one of the issue cases in #9420 seems to match your issue, i recommend trying that change-set to see if that fixes your issues

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

call `getfixturevalue` while `pytest_collection_modifyitems` #9689

Uh oh!

{{title}}

Uh oh!

Replies: 1 comment 12 replies

Uh oh!

{{title}}

Uh oh!

Uh oh!

{{title}}

Uh oh!

Uh oh!

{{title}}

Uh oh!

Uh oh!

{{title}}

Uh oh!

Uh oh!

{{editor}}'s edit

{{editor}}'s edit

Uh oh!

Uh oh!

{{title}}

Uh oh!

Uh oh!

{{title}}

Uh oh!

Select a reply

Uh oh!

Uh oh!

call getfixturevalue while pytest_collection_modifyitems #9689

Uh oh!

hfudev Feb 15, 2022

Replies: 1 comment · 12 replies

Uh oh!

RonnyPfannschmidt Feb 15, 2022 Maintainer

Uh oh!

hfudev Feb 15, 2022 Author

Uh oh!

RonnyPfannschmidt Feb 16, 2022 Maintainer

Uh oh!

Uh oh!

hfudev Feb 17, 2022 Author

Uh oh!

RonnyPfannschmidt Feb 17, 2022 Maintainer

Uh oh!

RonnyPfannschmidt Feb 19, 2022 Maintainer

call `getfixturevalue` while `pytest_collection_modifyitems` #9689

hfudev
Feb 15, 2022

Replies: 1 comment 12 replies

RonnyPfannschmidt
Feb 15, 2022
Maintainer

hfudev Feb 15, 2022
Author

RonnyPfannschmidt Feb 16, 2022
Maintainer

hfudev Feb 17, 2022
Author

RonnyPfannschmidt Feb 17, 2022
Maintainer

RonnyPfannschmidt Feb 19, 2022
Maintainer