multiple cli commands not working with pytest_generate_tests

[Montekkundan]

Hi, I'm following this, pytest_generate_url
As they explain, i too followed similar steps for my project:

# contents of test_parking

def test_parking(browser):    
    run = Checker(data["test_parking"]["url"], browser)

# contents of contest.py

def pytest_addoption(parser):
    parser.addoption('--type', action='store', help='store browser')


def pytest_generate_tests(metafunc):
    if "browser" in metafunc.fixturenames:
        parameters = []
        ids = []
        if metafunc.config.getoption("type") == "chrome":
            parameters += [webdriver.Chrome(service=Service(ChromeDriverManager().install()), options=chrome_options)]
            ids += ["chrome"]
            metafunc.parametrize("browser", parameters, ids=ids)
        if metafunc.config.getoption("type") == "firefox":
            parameters += [webdriver.Firefox(service=Service(GeckoDriverManager().install()), options=firefox_options)]
            ids += ["firefox"]
            metafunc.parametrize("browser", parameters, ids=ids)

Now when i run pytest --type="chrome" tests/test_parking.py it works great but when i add an additional argument like:
pytest --type="chrome" --type="firefox" tests/test_parking.py it only one test and that for firefox.

How can i make it so that there are individual 2 test for reach argument.

[RonnyPfannschmidt]

You are only supposed to call Parametrize once, unfortunately you call it for each cli arg

[Montekkundan]

If i update my code like this and call Parametrize once :

def pytest_generate_tests(metafunc):
    if "browser" in metafunc.fixturenames:
        parameters = []
        ids = []
        if metafunc.config.getoption("type") == "chrome":
            parameters += [webdriver.Chrome(service=Service(ChromeDriverManager().install()), options=chrome_options)]
            ids += ["chrome"]
        if metafunc.config.getoption("type") == "firefox":
            parameters += [webdriver.Firefox(service=Service(GeckoDriverManager().install()), options=firefox_options)]
            ids += ["firefox"]
        metafunc.parametrize("browser", parameters, ids=ids)

It still only works for firefox with the command pytest --type="chrome" --type="firefox" tests/test_parking.py
using individual commands like pytest --type="chrome" tests/test_parking.py is working.

[Montekkundan]

Update

I tried checking if two different tests are collected with only giving the parameters.

def pytest_generate_tests(metafunc):
    parameters = [
        webdriver.Chrome(service=Service(ChromeDriverManager().install()), options=chrome_options),
        webdriver.Firefox(service=Service(GeckoDriverManager().install()), options=firefox_options)
    ]
    ids = ["chrome", "firefox"]
    metafunc.parametrize("browser", parameters, ids=ids)

This works great, now the problem arises when i want to accept multiple cli arguments.