Suddenly started getting UnmockedError: No mocking was registered

[julianonunes]

I was changing my test to use the @pytest.mark.parametrize and after a few changes it starts crashing with the error "httpretty.errors.UnmockedError: No mocking was registered, and real connections are not allowed (httpretty.allow_net_connect = False).".

I checked the test results and at the beginning it mentions the MagicMock objects created, however the stack trace (and the debug process) shows that the mocker.patch seems to be ignored, as the real function is being called, instead of just returning what's on the def search_tickets(mocker, new_ticket).

What am I missing?

Here is a sample of my test:

@pytest.fixture
def new_ticket():
    ticket = Ticket(
        id=1,
        tags=[TAG_A],
        created_at=datetime.now(pytz.utc),
    )
    return ticket


@pytest.fixture
def search_tickets(mocker, new_ticket):
    patch = mocker.patch("path.search_tickets",
                         return_value=[new_ticket])

    return new_ticket, patch


@pytest.fixture
def get_ticket(mocker, new_ticket):
    mocker.patch("path.get_ticket",
                 return_value=new_ticket)
    return new_ticket


@pytest.fixture
def new_comment(mocker, request):
    comment = Comment(created_at=request.param)

    return mocker.patch(
        "path.search_comments",
        return_value=[comment],
    )


@pytest.fixture
def mocker_create_ticket(mocker):
    ticket = Ticket(
        id=0,
        tags=[TAG_B],
        created_at=datetime.now(pytz.utc),
    )

    return mocker.patch("path.create_ticket", return_value=ticket)


@pytest.mark.parametrize("new_comment",
                         [datetime.now(pytz.utc), datetime.now(pytz.utc) - timedelta(minutes=26)], indirect=True)
@pytest.mark.usefixtures("new_comment", "get_ticket")
def test_run_multiple_packages_dispute_automation(
    search_tickets, mock_update_ticket, mocker_create_ticket
):
    ticket, _ = search_tickets
    run_process() # stepping into this method I can see the real "path.search_tickets" function being called instead of being intercepted by the patch defined on search_tickets fixture

    # here the asserts begin...

[nicoddemus]

Nothing jumps to the eyes looking at the code... any chance of providing a minimal reproducible example?

[julianonunes]

I've created an example that mimics most of the test and the code being tested, but in this case it passes. I have also put some print in the real functions to check if the patch works, but nothing gets printed (at least I think it should print if patch didn't work).

from datetime import datetime, timedelta

import pytest
import pytz

TAG_A = "A"
TAG_B = "B"

class Ticket:
    def __init__(self, id, tags, status, created_at):
        self.id = id
        self.tags = tags
        self.status = status
        self.created_at = created_at


class Comment:
    def __init__(self, body, created_at):
        self.body = body
        self.created_at = created_at

def search_tickets(param1, param2):
    print('search_tickets')
    return [Ticket(1, [TAG_A, TAG_B], "new", datetime.now(pytz.utc))]

def create_ticket():
    print('create_ticket')

def get_ticket():
    print('get_ticket')
    return Ticket(1, [TAG_A, TAG_B], "new", datetime.now(pytz.utc))

def search_comments():
    print('search_comments')
    return [Comment("Body", datetime.now(pytz.utc))]

def create_child_ticket(id: int):
    comments = search_comments()

    for comment in comments:
        current_ticket = get_ticket()
        other_tickets = search_tickets("A", "A")


def process_tickets():
    tickets = search_tickets("A", "A")

    for ticket in tickets:
        create_child_ticket(ticket.id)

def run_process():
    print('run_process')
    process_tickets()

@pytest.fixture
def new_ticket():
    ticket = Ticket(
        id=1,
        tags=[TAG_A],
        status="NEW",
        created_at=datetime.now(pytz.utc),
    )
    return ticket


@pytest.fixture
def mock_search_tickets(mocker, new_ticket):
    patch = mocker.patch("repro.search_tickets",
                         return_value=[new_ticket])

    return new_ticket, patch


@pytest.fixture
def mock_get_ticket(mocker, new_ticket):
    mocker.patch("repro.get_ticket",
                 return_value=new_ticket)
    return new_ticket

@pytest.fixture
def mock_new_comment(mocker, request):
    comment = Comment(body="", created_at=request.param)

    return mocker.patch(
        "repro.search_comments",
        return_value=[comment],
    )


@pytest.fixture
def mocker_create_ticket(mocker):
    ticket = Ticket(
        id=0,
        tags=[TAG_B],
        status="NEW",
        created_at=datetime.now(pytz.utc),
    )

    return mocker.patch("repro.create_ticket", return_value=ticket)

@pytest.mark.parametrize("mock_new_comment",
                         [datetime.now(pytz.utc), datetime.now(pytz.utc) - timedelta(minutes=26)], indirect=True)
@pytest.mark.usefixtures("mock_new_comment", "mock_get_ticket")
def test_run_tickets(mock_search_tickets, mocker_create_ticket):
    ticket, _ = mock_search_tickets
    run_process()

Tomorrow I'll check the real code once more and let you know. 😞

[julianonunes]

Had to try once more before bed 😄...I've found the cause but I confess I don't quite understand the reason.

Previously the py file being tested had local import for one of the functions being patched:

# actually this function is inside another py file
def search_tickets(param1, param2):
    print('search_tickets')
    return [Ticket(1, [TAG_A, TAG_B], "new", datetime.now(pytz.utc))]

def process_tickets():
    # the code used to be like this before
    from other_file import search_tickets
    tickets = search_tickets("A", "A")

    for ticket in tickets:
        create_child_ticket(ticket.id)

however I changed that by moving the from other_file import search_tickets outside the function scope.
To make it work, I had to change this:

@pytest.fixture
def mock_search_tickets(mocker, new_ticket):
    patch = mocker.patch("other_file.search_tickets",
                         return_value=[new_ticket])

    return new_ticket, patch

to this:

@pytest.fixture
def mock_search_tickets(mocker, new_ticket):
    # notice the path here, despite the function implementation being on other_file.search_tickets, I had to use the path to the file (repro) importing it
    patch = mocker.patch("repro.search_tickets",
                         return_value=[new_ticket])

    return new_ticket, patch

Shouldn't it work by using the function source path?

[nicoddemus]

Ahh OK that explains it. See the documentation which explains this in detail. 👍