Allow disabling argument quoting with `run` function for WinRM backends

[cowdude]

Hello,

Consider the following basic WinRM test:

def test_echo(host):
    hello = 'Hello, world!'
    res = host.run('echo %s', hello)
    assert res.stdout == hello # Fails

    assert res.stdout== hello
E   assert '"Hello, world!"\r\n' == 'Hello, world!'
# I'm fine with that extra CRLF, but the quotes bugged me for some time...

Related log entry:
INFO:testinfra:RUN CommandResult(command='echo "Hello, world!"', exit_status=0, stdout=b'"Hello, world!"\r\n', stderr=None)

It would be nice to be able to turn off argument quoting for executables which behave like MS echo (they echo back quotes, apparently 🐼 ). Pywinrm already seems to handle arguments escaping/quoting, but I haven't played much with this library yet. It could be possible to let pywinrm handle the command formatting/escaping.

Unrelated to this issue, worth mentioning: the CommandResult.stdout value is a binary string instead of a string when using run with WinRM. Is it intended?

[philpep]

Hi, thanks for reporting the issue!

In the API, attributes of CommandResult stdout and stderr should be string and stdout_bytes and stderr_bytes should be bytes (in general case, backends store bytes which are decoded when the user ask for strings.

Take care that the displayed message is confusing because it display 'CommandResult(stdout={})'.format(self.stdout_bytes or self.stdout). So I think in your case it display stdout_bytes.

For the issue with quoting, looks like a bug. We have a custom quoting method introduced by https://github.com/philpep/testinfra/pull/240/files which may be broken. I'm not a windows expert, so help would be very appreciated!