Cleaned up code following @jmcouffins suggestions

Author: EF

extensions/pyRevitTools.extension/pyRevit.tab/Analysis.panel/Tools.stack/Analyse.pulldown/Get Openings.pushbutton/bundle.yaml

@@ -0,0 +1,13 @@
+title:
+  ru: Получить отверстия
+  fr_fr: Obtenir les ouvertures
+  en_us: Get Openings
+  de_de: Öffnungen ermitteln
+tooltip: >
+  en_us: |
+    Scans through the project for openings. A list with clickable links will be presented. Open a 3D view to access and see the selected openings. A selection filter will be created or updated to select all openings with one click.
+  de_de: |
+    Durchsucht das Projekt nach Öffnungen. Eine Liste mit anklickbaren Links wird angezeigt. Öffnen Sie eine 3D-Ansicht, um auf die ausgewählten Öffnungen zuzugreifen und diese zu sehen. Es wird ein Auswahlfilter erstellt oder aktualisiert, um alle Öffnungen mit einem Klick auszuwählen.
+  fr_fr: |
+    Examine le projet à la recherche d'ouvertures. Une liste avec des liens cliquables sera présentée. Ouvrez une vue 3D pour accéder et voir les ouvertures sélectionnées. Un filtre de sélection sera créé ou mis à jour pour sélectionner toutes les ouvertures en un seul clic.
+authors: Jakob Steiner, inspired by the initial work of Andreas Draxl, Mohamed Bedair, special thanks to Erik Frits

extensions/pyRevitTools.extension/pyRevit.tab/Analysis.panel/Tools.stack/Analyse.pulldown/Get Openings.pushbutton/icon.dark.png

@@ -1,39 +1,17 @@
 # -*- coding: utf-8 -*-
 
-__title__  = "Get Openings"
-__author__  = "Jakob Steiner"
-__doc__ = """Version = 1.1
-Date    = 24.03.2024
-_____________________________________________________________________
-Scans trough the project for openings. A list with clickable
-links will be presented. Open a 3D view to acces and see the
-selected openings. A selection Filter will be created or
-update to select all openings with one click.
-
-Inspired by the initial work of Mohamed Bedair and Andreas Draxl.
-Special thanks to Erik Frits for his help.
-_____________________________________________________________________
-REQUIREMENTS:
-_____________________________________________________________________
-[24.03.2024] - Added selection Filter
-[23.03.2024] - 1.0 First Release"""
-
-# IMPORTS
-
-# .NET
-import clr
-clr.AddReference('System')
-from System.Collections.Generic import List
+"""Lists all openings in the project and creates 
+a selection filter for them."""
+
+# Sytem
 import time
 
 # Revit
-from Autodesk.Revit.UI.Selection import *
-from Autodesk.Revit.DB import *
+from Autodesk.Revit.DB import BuiltInCategory, ElementMulticategoryFilter, FilteredElementCollector, Opening, SelectionFilterElement, Transaction, ElementId
 
 # pyRevit
-from pyrevit import *
 from pyrevit import script
-
+from pyrevit.framework import List
 doc         =__revit__.ActiveUIDocument.Document
 uidoc       =__revit__.ActiveUIDocument
 output      = script.get_output()
@@ -103,10 +81,8 @@
     if t.HasStarted():
         t.RollBack()
     script.exit(str(ex))
-# ╦═╗╔═╗╔═╗╔═╗╦═╗╔╦╗╔═╗
-# ╠╦╝║╣ ╠═╝║ ║╠╦╝ ║ ╚═╗
-# ╩╚═╚═╝╩  ╚═╝╩╚═ ╩ ╚═╝
-#==================================================
+
+# Report
 
 output.print_md("#### There are {} openings (floor, wall, shaft, roof) in the project.".format(len(all_elements))) # TO DO Output link for all.
 if data: