Merge pull request #2619 from Wurschdhaud/develop

dev/#2606 Fix for orienting section box to faces of objects that have transformations

Author: jmcouffin

extensions/pyRevitTools.extension/pyRevit.tab/Modify.panel/3D.pulldown/Orient Section Box To Face.pushbutton/bundle.yaml

@@ -14,3 +14,4 @@ tooltip:
     Fläche im Modell ausgewählt werden. Mit der TAB Taste kann man zwischen angrenzenden
     Flächen durchwechseln. Eine Seite des 3D-Schnittbereichs übernimmt die 
     Ausrichtung der gewählten Fläche!
+context: active-3d-view

extensions/pyRevitTools.extension/pyRevit.tab/Modify.panel/3D.pulldown/Orient Section Box To Face.pushbutton/script.py

@@ -4,39 +4,63 @@
 from pyrevit import revit, DB, UI
 from pyrevit import forms
 
+from Autodesk.Revit.UI.Selection import ObjectType
 
 curview = revit.active_view
 
 
 def orientsectionbox(view):
-        try:
-            face = revit.pick_face()
-            box = view.GetSectionBox()
-            norm = face.ComputeNormal(DB.UV(0, 0)).Normalize()
-            boxNormal = box.Transform.Basis[0].Normalize()
-            angle = norm.AngleTo(boxNormal)
-            axis = DB.XYZ(0, 0, 1.0)
-            origin = DB.XYZ(box.Min.X + (box.Max.X - box.Min.X) / 2,
-                            box.Min.Y + (box.Max.Y - box.Min.Y) / 2, 0.0)
-            if norm.Y * boxNormal.X < 0:
-                rotate = \
-                    DB.Transform.CreateRotationAtPoint(axis, Math.PI / 2 - angle,
-                                                       origin)
-            else:
-                rotate = DB.Transform.CreateRotationAtPoint(axis,
-                                                            angle,
-                                                            origin)
-            box.Transform = box.Transform.Multiply(rotate)
-            with revit.Transaction('Orient Section Box to Face'):
-                view.SetSectionBox(box)
-                revit.uidoc.RefreshActiveView()
-        except Exception:
-            pass
+    try:
+        # Pick face to align to using uidoc.Selection instead of revit.pick_face to get the reference instead of the face
+        face = revit.uidoc.Selection.PickObject(
+            UI.Selection.ObjectType.Face, "Pick a face to align to:"
+        )
+
+        # Get the section box
+        box = view.GetSectionBox()
+
+        # Get the geometry object of the reference
+        element = revit.doc.GetElement(face)
+        geometry_object = element.GetGeometryObjectFromReference(face)
+
+        # Check if the object might have a Transformation (by checking if it's Non-Instance)
+        if isinstance(element, DB.FamilyInstance):
+            # Get the transform of the family instance (converts local to world coordinates)
+            transform = element.GetTransform()
+            # Get the face normal in local coordinates
+            local_normal = geometry_object.ComputeNormal(DB.UV(0, 0)).Normalize()
+            # Apply the transform to convert normal to world coordinates
+            world_normal = transform.OfVector(local_normal).Normalize()
+            norm = world_normal
+        else:
+            norm = geometry_object.ComputeNormal(DB.UV(0, 0)).Normalize()
+
+        # Orient the box
+        boxNormal = box.Transform.Basis[0].Normalize()
+        angle = norm.AngleTo(boxNormal)
+        axis = DB.XYZ(0, 0, 1.0)
+        origin = DB.XYZ(
+            box.Min.X + (box.Max.X - box.Min.X) / 2,
+            box.Min.Y + (box.Max.Y - box.Min.Y) / 2,
+            0.0,
+        )
+        if norm.Y * boxNormal.X < 0:
+            rotate = DB.Transform.CreateRotationAtPoint(
+                axis, Math.PI / 2 - angle, origin
+            )
+        else:
+            rotate = DB.Transform.CreateRotationAtPoint(axis, angle, origin)
+        box.Transform = box.Transform.Multiply(rotate)
+        with revit.Transaction("Orient Section Box to Face"):
+            view.SetSectionBox(box)
+            revit.uidoc.RefreshActiveView()
+    except Exception as ex:
+        forms.alert("Error: {0}".format(str(ex)))
 
 
 if isinstance(curview, DB.View3D) and curview.IsSectionBoxActive:
     orientsectionbox(curview)
 elif isinstance(curview, DB.View3D) and not curview.IsSectionBoxActive:
     forms.alert("The section box for View3D isn't active.")
 else:
-    forms.alert('You must be on a 3D view for this tool to work.')
+    forms.alert("You must be on a 3D view for this tool to work.")