Merge branch 'develop' into fix/2570

Author: jmcouffin

extensions/pyRevitTools.extension/pyRevit.tab/Analysis.panel/Tools.stack/Analyse.pulldown/Get Openings.pushbutton/bundle.yaml

@@ -0,0 +1,13 @@
+title:
+  ru: Получить отверстия
+  fr_fr: Obtenir les ouvertures
+  en_us: Get Openings
+  de_de: Öffnungen ermitteln
+tooltip: >
+  en_us: |
+    Scans through the project for openings. A list with clickable links will be presented. Open a 3D view to access and see the selected openings. A selection filter will be created or updated to select all openings with one click.
+  de_de: |
+    Durchsucht das Projekt nach Öffnungen. Eine Liste mit anklickbaren Links wird angezeigt. Öffnen Sie eine 3D-Ansicht, um auf die ausgewählten Öffnungen zuzugreifen und diese zu sehen. Es wird ein Auswahlfilter erstellt oder aktualisiert, um alle Öffnungen mit einem Klick auszuwählen.
+  fr_fr: |
+    Examine le projet à la recherche d'ouvertures. Une liste avec des liens cliquables sera présentée. Ouvrez une vue 3D pour accéder et voir les ouvertures sélectionnées. Un filtre de sélection sera créé ou mis à jour pour sélectionner toutes les ouvertures en un seul clic.
+authors: Jakob Steiner, inspired by the initial work of Andreas Draxl, Mohamed Bedair, special thanks to Erik Frits

extensions/pyRevitTools.extension/pyRevit.tab/Analysis.panel/Tools.stack/Analyse.pulldown/Get Openings.pushbutton/icon.dark.png

@@ -0,0 +1,79 @@
+# -*- coding: utf-8 -*-
+
+"""Lists all openings in the project and creates 
+a selection filter for them."""
+
+# Sytem
+import time
+
+# pyRevit
+from pyrevit import revit, script, DB
+from pyrevit.framework import List
+doc         =__revit__.ActiveUIDocument.Document
+uidoc       =__revit__.ActiveUIDocument
+output      = script.get_output()
+selection   = uidoc.Selection
+timer_start = time.time()
+
+# GET ALL OPENINGS IN THE PROJECT
+
+# List of categories
+cats = [DB.BuiltInCategory.OST_FloorOpening,
+        DB.BuiltInCategory.OST_SWallRectOpening,
+        DB.BuiltInCategory.OST_ShaftOpening,
+        DB.BuiltInCategory.OST_RoofOpening]
+list_cats = List[DB.BuiltInCategory](cats)
+
+# Create filter
+multi_cat_filter = DB.ElementMulticategoryFilter(list_cats)
+
+# Apply filter to filteredElementCollector
+all_elements = DB.FilteredElementCollector(doc)\
+                .WherePasses(multi_cat_filter)\
+                .WhereElementIsNotElementType()\
+                .ToElements()
+
+# Get elements for selection filter
+element_ids = DB.FilteredElementCollector(doc).OfClass(DB.Opening).ToElementIds()
+element_ids = List[DB.ElementId](element_ids)
+
+# Declaration of a list to contains list of wanted element properties
+data = []
+
+# Collect information about the object and put it into in the data list.
+for e in all_elements:
+    el = []
+    el.append(e.Name)
+    el.append(e.Id)
+    # add IFC Classification if parameter exist
+    e_link = output.linkify(e.Id)
+    el.append(e_link)
+    data.append(el)
+
+# Get All Selection Filters
+all_sel_filters  = DB.FilteredElementCollector(doc).OfClass(DB.SelectionFilterElement).ToElements()
+dict_sel_filters = {f.Name: f for f in all_sel_filters}
+
+# Transaction to create a new selection filter
+with revit.Transaction('Create Openings Filter'):
+    new_filter_name = '0_ShaftOpenings'
+    if new_filter_name not in dict_sel_filters:
+        new_fil = DB.SelectionFilterElement.Create(doc, new_filter_name)
+        new_fil.AddSet(element_ids)
+        print ('Created a filter called : {}'.format(new_filter_name))
+    else:
+        existing_fil = dict_sel_filters[new_filter_name]
+        existing_fil.AddSet(element_ids)
+        print ('Updated a filter called : {}'.format(new_filter_name))
+
+# Report
+output.print_md("#### There are {} openings (floor, wall, shaft, roof) in the project.".format(len(all_elements))) # TO DO Output link for all.
+if data:
+    output.print_table(table_data=data, title="Shafts:", columns=["Family" ,"ElementId", "Select/Show Element"])
+    #output.print_md("#####Total {} WDB/WA elements has been updated.".format(len(data)))
+else:
+    output.print_md("#####There are no openings (floor, wall, shaft, roof) in the project")
+
+# End
+output.print_md('---')
+output.print_md('#### Script has finished in {}s'.format(time.time() - timer_start))

extensions/pyRevitTools.extension/pyRevit.tab/Analysis.panel/Tools.stack/Analyse.pulldown/Get Openings.pushbutton/icon.png

@@ -237,7 +237,7 @@
         untagged_elements = []
         for eltid in target_tags:
             elt = revit.doc.GetElement(eltid)
-            elif HOST_APP.is_newer_than(2022, or_equal=True):
+            if HOST_APP.is_newer_than(2022, or_equal=True):
                 if elt.GetTaggedLocalElementIds() != DB.ElementId.InvalidElementId:
                     tagged_elements.append(List[DB.ElementId](get_elementid_value(elt.GetTaggedLocalElementIds())[0]))
             else:

extensions/pyRevitTools.extension/pyRevit.tab/Analysis.panel/Tools.stack/Analyse.pulldown/Get Openings.pushbutton/script.py

@@ -1178,7 +1178,7 @@ def get_rvt_link_doc_name(rvtlink_instance):
     Returns:
         str: The name of the Revit link document, without the file extension and any directory paths.
     """
-    return get_name(rvtlink_instance).split(" \ ")[0].split(".rvt")[0]
+    return get_name(rvtlink_instance).split("\\")[0].split(".rvt")[0]
 
 
 def get_rvt_link_instance_name(rvtlink_instance=None):