From c985cf6b22866dbf9faa4f5232bf769cc7a20e44 Mon Sep 17 00:00:00 2001 From: toensoff Date: Fri, 20 Sep 2024 12:03:32 +0200 Subject: [PATCH 1/3] fix offset in LinearEmbeddingEncoder --- torch_frame/nn/encoder/stype_encoder.py | 1 + 1 file changed, 1 insertion(+) diff --git a/torch_frame/nn/encoder/stype_encoder.py b/torch_frame/nn/encoder/stype_encoder.py index 88a0e5be9..1b12c1891 100644 --- a/torch_frame/nn/encoder/stype_encoder.py +++ b/torch_frame/nn/encoder/stype_encoder.py @@ -732,6 +732,7 @@ def encode_forward( # -> [batch_size, out_channels] x_lin = feat.values[:, start_idx:end_idx] @ self.weight_list[idx] x_lins.append(x_lin) + start_idx = end_idx # [batch_size, num_cols, out_channels] x = torch.stack(x_lins, dim=1) # [batch_size, num_cols, out_channels] + [num_cols, out_channels] From f3396d777e4e89923b57adcb79f78462a07148eb Mon Sep 17 00:00:00 2001 From: toensoff Date: Fri, 20 Sep 2024 13:12:40 +0200 Subject: [PATCH 2/3] update changelog --- CHANGELOG.md | 1 + 1 file changed, 1 insertion(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index 0aceabce1..a09dba354 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -7,6 +7,7 @@ The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/). ### Added +- Fixed offset in `LinearEmbeddingEncoder` [#455](https://github.com/pyg-team/pytorch-frame/pull/455) - Added a benchmark script to compare PyTorch Frame with PyTorch Tabular ([#398](https://github.com/pyg-team/pytorch-frame/pull/398), [#444](https://github.com/pyg-team/pytorch-frame/pull/444)) - Added `is_floating_point` method to `MultiNestedTensor` and `MultiEmbeddingTensor` ([#445](https://github.com/pyg-team/pytorch-frame/pull/445)) - Added support for inferring `stype.categorical` from boolean columns in `utils.infer_series_stype` ([#421](https://github.com/pyg-team/pytorch-frame/pull/421)) From c5d64157303bfc56335eb611d8d67faef04153c9 Mon Sep 17 00:00:00 2001 From: Akihiro Nitta Date: Fri, 20 Sep 2024 23:29:37 +0000 Subject: [PATCH 3/3] rm changelog --- CHANGELOG.md | 1 - 1 file changed, 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index a09dba354..0aceabce1 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -7,7 +7,6 @@ The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/). ### Added -- Fixed offset in `LinearEmbeddingEncoder` [#455](https://github.com/pyg-team/pytorch-frame/pull/455) - Added a benchmark script to compare PyTorch Frame with PyTorch Tabular ([#398](https://github.com/pyg-team/pytorch-frame/pull/398), [#444](https://github.com/pyg-team/pytorch-frame/pull/444)) - Added `is_floating_point` method to `MultiNestedTensor` and `MultiEmbeddingTensor` ([#445](https://github.com/pyg-team/pytorch-frame/pull/445)) - Added support for inferring `stype.categorical` from boolean columns in `utils.infer_series_stype` ([#421](https://github.com/pyg-team/pytorch-frame/pull/421))