Skip to content

Commit ec3db1e

Browse files
committed
Update the tests for DICOM version 2025c
1 parent 25a8937 commit ec3db1e

File tree

8 files changed

+20
-19
lines changed

8 files changed

+20
-19
lines changed

.github/workflows/testsuite.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -27,15 +27,15 @@ jobs:
2727
uses: actions/cache@v4
2828
with:
2929
path: dicom_validator/tests/fixtures/standard
30-
key: "2015b_2025b"
30+
key: "2015b_2025c"
3131
enableCrossOsArchive: true
3232

3333
- name: Download DICOM standard
3434
if: steps.cache-dicom.outputs.cache-hit != 'true'
3535
run: |
3636
pip install -e .
3737
python .github/workflows/get_revision.py 2015b "`pwd`/dicom_validator/tests/fixtures/standard"
38-
python .github/workflows/get_revision.py 2025b "`pwd`/dicom_validator/tests/fixtures/standard"
38+
python .github/workflows/get_revision.py 2025c "`pwd`/dicom_validator/tests/fixtures/standard"
3939
4040
- name: Install dependencies
4141
run: |

CHANGES.md

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,8 @@ The released versions correspond to PyPi releases.
44
## Unreleased
55

66
### Infrastructure
7-
* add Python 3.14 to CI (needs development version of `pydicom`)
7+
* updated the tests for current DICOM version 2025c
8+
* added Python 3.14 to CI (needs development version of `pydicom`)
89

910
## [Version 0.7.1](https://pypi.python.org/pypi/dicom-validator/0.7.1) (2025-05-25)
1011
Fixes condition parser problems with newest DICOM standard.
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
["2014a", "2014b", "2014c", "2015a", "2015b", "2015c", "2016a", "2016b", "2016c", "2016d", "2016e", "2017a", "2017b", "2017c", "2017d", "2017e", "2018a", "2018b", "2018c", "2018d", "2018e", "2019a", "2019b", "2019c", "2019d", "2019e", "2020a", "2020b", "2020c", "2020d", "2020e", "2021a", "2021b", "2021c", "2021d", "2021e", "2022a", "2022b", "2022c", "2022d", "2022e", "2023a", "2023b", "2023c", "2023d", "2023e", "2024a", "2024b", "2024c", "2024d", "2024e", "2025a", "2025b"]
1+
["2014a", "2014b", "2014c", "2015a", "2015b", "2015c", "2016a", "2016b", "2016c", "2016d", "2016e", "2017a", "2017b", "2017c", "2017d", "2017e", "2018a", "2018b", "2018c", "2018d", "2018e", "2019a", "2019b", "2019c", "2019d", "2019e", "2020a", "2020b", "2020c", "2020d", "2020e", "2021a", "2021b", "2021c", "2021d", "2021e", "2022a", "2022b", "2022c", "2022d", "2022e", "2023a", "2023b", "2023c", "2023d", "2023e", "2024a", "2024b", "2024c", "2024d", "2024e", "2025a", "2025b","2025c"]

dicom_validator/tests/spec_reader/conftest.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33

44
import pytest
55

6-
CURRENT_REVISION = "2025b"
6+
CURRENT_REVISION = "2025c"
77

88

99
def pytest_configure(config):

dicom_validator/tests/spec_reader/test_part3_reader.py

Lines changed: 11 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,7 @@ def test_read_incomplete_doc_file(self, fs):
5050

5151
@pytest.mark.parametrize(
5252
"revision,iod_name",
53-
[("2015b", "Computed Tomography Image IOD"), ("2025b", "CT Image IOD")],
53+
[("2015b", "Computed Tomography Image IOD"), ("2025c", "CT Image IOD")],
5454
indirect=["revision"],
5555
scope="session",
5656
)
@@ -64,7 +64,7 @@ def test_lookup_sop_class(self, reader, iod_name):
6464

6565
@pytest.mark.parametrize(
6666
"revision,module_nr",
67-
[("2015b", 27), ("2025b", 29)],
67+
[("2015b", 27), ("2025c", 29)],
6868
indirect=["revision"],
6969
scope="session",
7070
)
@@ -78,7 +78,7 @@ def test_get_iod_modules(self, reader, module_nr):
7878
assert module["ref"] == "C.7.5.1"
7979
assert module["use"] == "M"
8080

81-
@pytest.mark.parametrize("revision", ["2015b", "2025b"], indirect=True)
81+
@pytest.mark.parametrize("revision", ["2015b", "2025c"], indirect=True)
8282
def test_optional_iod_module(self, reader):
8383
description = reader.iod_description(chapter="A.38.1")
8484
assert "modules" in description
@@ -90,7 +90,7 @@ def test_optional_iod_module(self, reader):
9090

9191
@pytest.mark.parametrize(
9292
"revision,desc_nr",
93-
[("2015b", 110), ("2025b", 157)],
93+
[("2015b", 110), ("2025c", 157)],
9494
indirect=["revision"],
9595
scope="session",
9696
)
@@ -103,7 +103,7 @@ def test_iod_descriptions(self, reader, desc_nr):
103103

104104
@pytest.mark.parametrize(
105105
"revision,macro_nr",
106-
[("2015b", 24), ("2025b", 28)],
106+
[("2015b", 24), ("2025c", 28)],
107107
indirect=["revision"],
108108
scope="session",
109109
)
@@ -137,7 +137,7 @@ def test_group_macros(self, reader, macro_nr):
137137

138138
@pytest.mark.parametrize(
139139
"revision,desc_nr",
140-
[("2015b", 9), ("2025b", 14)],
140+
[("2015b", 9), ("2025c", 14)],
141141
indirect=["revision"],
142142
scope="session",
143143
)
@@ -152,7 +152,7 @@ def test_module_description(self, reader, desc_nr):
152152

153153
@pytest.mark.parametrize(
154154
"revision,desc_nr, seq_desc_nr",
155-
[("2015b", 3, 3), ("2025b", 7, 4)],
155+
[("2015b", 3, 3), ("2025c", 7, 4)],
156156
indirect=["revision"],
157157
scope="session",
158158
)
@@ -183,7 +183,7 @@ def test_referenced_macro(self, reader):
183183

184184
@pytest.mark.parametrize(
185185
"revision,desc_nr",
186-
[("2015b", 451), ("2025b", 591)],
186+
[("2015b", 451), ("2025c", 592)],
187187
indirect=["revision"],
188188
scope="session",
189189
)
@@ -193,7 +193,7 @@ def test_module_descriptions(self, reader, desc_nr):
193193

194194
@pytest.mark.parametrize(
195195
"revision,include_nr",
196-
[("2015b", 9), ("2025b", 10)],
196+
[("2015b", 9), ("2025c", 10)],
197197
indirect=["revision"],
198198
scope="session",
199199
)
@@ -226,7 +226,7 @@ def test_parsed_enum_values(self, reader):
226226
assert enums == [{"val": ["FAILURE", "WARNING", "INFORMATIVE"]}]
227227

228228
@pytest.mark.parametrize(
229-
"revision", ["2015b", "2025b"], indirect=True, scope="session"
229+
"revision", ["2015b", "2025c"], indirect=True, scope="session"
230230
)
231231
def test_linked_enum_values(self, reader):
232232
description = reader.module_description("10.24")
@@ -239,7 +239,7 @@ def test_linked_enum_values(self, reader):
239239
assert tag["enums"] == [{"val": ["CONTINUOUS", "TRIGGERED", "AUTOMATIC"]}]
240240

241241
@pytest.mark.parametrize(
242-
"revision", ["2015b", "2025b"], indirect=True, scope="session"
242+
"revision", ["2015b", "2025c"], indirect=True, scope="session"
243243
)
244244
def test_graphic_annotation_sequence(self, reader):
245245
description = reader.module_description("C.10.5")

dicom_validator/tests/spec_reader/test_part6_reader.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ def test_data_element(self, dict_reader):
1515

1616
def test_data_elements(self, dict_reader):
1717
elements = dict_reader.data_elements()
18-
assert len(elements) == 5249
18+
assert len(elements) == 5250
1919

2020
def test_sop_class_uids(self, dict_reader):
2121
sop_class_uids = dict_reader.sop_class_uids()

dicom_validator/tests/test_cmdline_tools.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ def dicom_fixture_path(fixture_path):
2222

2323

2424
@pytest.mark.order(0)
25-
@pytest.mark.parametrize("revision", ["2015b", "2025b"])
25+
@pytest.mark.parametrize("revision", ["2015b", "2025c"])
2626
def test_validate_sr(revision, caplog, standard_path, dicom_fixture_path):
2727
# test also for 2015b to test an issue causing an exception
2828
rtdose_path = dicom_fixture_path / "rtdose.dcm"

dicom_validator/tests/validator/conftest.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
from dicom_validator.spec_reader.edition_reader import EditionReader
88
from dicom_validator.validator.iod_validator import DicomInfo
99

10-
CURRENT_REVISION = "2025b"
10+
CURRENT_REVISION = "2025c"
1111

1212

1313
def pytest_configure(config):

0 commit comments

Comments
 (0)