Skip to content

Commit fab900c

Browse files
authored
dask tests: Avoid check for non-copies, xfail pandas comparison (#9857)
1 parent 99ee8c6 commit fab900c

File tree

2 files changed

+12
-14
lines changed

2 files changed

+12
-14
lines changed

xarray/tests/test_dask.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -791,6 +791,7 @@ def test_tokenize_duck_dask_array(self):
791791

792792

793793
class TestToDaskDataFrame:
794+
@pytest.mark.xfail(reason="https://github.com/dask/dask/issues/11584")
794795
def test_to_dask_dataframe(self):
795796
# Test conversion of Datasets to dask DataFrames
796797
x = np.random.randn(10)

xarray/tests/test_variable.py

Lines changed: 11 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -278,34 +278,30 @@ def test_0d_time_data(self):
278278
@pytest.mark.filterwarnings("ignore:Converting non-nanosecond")
279279
def test_datetime64_conversion(self):
280280
times = pd.date_range("2000-01-01", periods=3)
281-
for values, preserve_source in [
282-
(times, True),
283-
(times.values, True),
284-
(times.values.astype("datetime64[s]"), False),
285-
(times.to_pydatetime(), False),
281+
for values in [
282+
times,
283+
times.values,
284+
times.values.astype("datetime64[s]"),
285+
times.to_pydatetime(),
286286
]:
287287
v = self.cls(["t"], values)
288288
assert v.dtype == np.dtype("datetime64[ns]")
289289
assert_array_equal(v.values, times.values)
290290
assert v.values.dtype == np.dtype("datetime64[ns]")
291-
same_source = source_ndarray(v.values) is source_ndarray(values)
292-
assert preserve_source == same_source
293291

294292
@pytest.mark.filterwarnings("ignore:Converting non-nanosecond")
295293
def test_timedelta64_conversion(self):
296294
times = pd.timedelta_range(start=0, periods=3)
297-
for values, preserve_source in [
298-
(times, True),
299-
(times.values, True),
300-
(times.values.astype("timedelta64[s]"), False),
301-
(times.to_pytimedelta(), False),
295+
for values in [
296+
times,
297+
times.values,
298+
times.values.astype("timedelta64[s]"),
299+
times.to_pytimedelta(),
302300
]:
303301
v = self.cls(["t"], values)
304302
assert v.dtype == np.dtype("timedelta64[ns]")
305303
assert_array_equal(v.values, times.values)
306304
assert v.values.dtype == np.dtype("timedelta64[ns]")
307-
same_source = source_ndarray(v.values) is source_ndarray(values)
308-
assert preserve_source == same_source
309305

310306
def test_object_conversion(self):
311307
data = np.arange(5).astype(str).astype(object)
@@ -2372,6 +2368,7 @@ def test_dask_rolling(self, dim, window, center):
23722368
assert actual.shape == expected.shape
23732369
assert_equal(actual, expected)
23742370

2371+
@pytest.mark.xfail(reason="https://github.com/dask/dask/issues/11585")
23752372
def test_multiindex(self):
23762373
super().test_multiindex()
23772374

0 commit comments

Comments
 (0)