Skip to content

Commit f2e917a

Browse files
committed
clarify
1 parent 12c4943 commit f2e917a

File tree

1 file changed

+4
-10
lines changed

1 file changed

+4
-10
lines changed

xarray/tests/__init__.py

Lines changed: 4 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -134,22 +134,16 @@ def _importorskip(
134134
if has_zarr_v3:
135135
import zarr
136136

137+
# manual update by checking attrs for now
138+
# TODO: use version specifier
139+
# installing from git main is giving me a lower version than the
140+
# most recently released zarr
137141
has_zarr_v3_dtypes = hasattr(zarr.core, "dtype")
138142

139-
# has_zarr_v3_dtypes = hasattr(zarr.Array.metadata.data_type, "to_native_dtype")
140143
requires_zarr_v3_dtypes = pytest.mark.skipif(
141144
not has_zarr_v3_dtypes, reason="requires zarr>3.0.10 (including dev versions)"
142145
)
143146

144-
# Additional check for zarr dtype support (dev versions > 3.0.9)
145-
# if has_zarr:
146-
# import zarr
147-
#
148-
# # Dev versions like "3.0.10.dev47+g9da38f75" are > "3.0.10"
149-
# has_zarr_v3_dtypes = has_zarr_v3_dtypes or (
150-
# Version(zarr.__version__) > Version("3.0.10")
151-
# )
152-
153147
has_fsspec, requires_fsspec = _importorskip("fsspec")
154148
has_iris, requires_iris = _importorskip("iris")
155149
has_numbagg, requires_numbagg = _importorskip("numbagg")

0 commit comments

Comments
 (0)