Skip to content

Commit 12022cc

Browse files
authored
Fix Zarr 'number of requests' test (#10492)
1 parent ad25833 commit 12022cc

File tree

2 files changed

+9
-9
lines changed

2 files changed

+9
-9
lines changed

xarray/tests/conftest.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -234,6 +234,6 @@ def simple_datatree(create_test_datatree):
234234
return create_test_datatree()
235235

236236

237-
@pytest.fixture(scope="module", params=["s", "ms", "us", "ns"])
237+
@pytest.fixture(params=["s", "ms", "us", "ns"])
238238
def time_unit(request):
239239
return request.param

xarray/tests/test_backends.py

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -3545,8 +3545,8 @@ def test_append(self) -> None:
35453545
if has_zarr_v3:
35463546
# TODO: verify these
35473547
expected = {
3548-
"set": 16,
3549-
"get": 8, # TODO: fixme upstream (should be 4), see https://github.com/zarr-developers/zarr-python/issues/3199
3548+
"set": 5,
3549+
"get": 4,
35503550
"list_dir": 2,
35513551
"list_prefix": 1,
35523552
}
@@ -3570,8 +3570,8 @@ def test_append(self) -> None:
35703570
# 6057128b: {'iter': 5, 'contains': 2, 'setitem': 5, 'getitem': 10, "listdir": 5, "list_prefix": 0}
35713571
if has_zarr_v3:
35723572
expected = {
3573-
"set": 11, # TODO: fixme upstream (should be 4), see https://github.com/zarr-developers/zarr-python/issues/3199
3574-
"get": 23, # TODO: fixme upstream (should be 8), see https://github.com/zarr-developers/zarr-python/issues/3199
3573+
"set": 4,
3574+
"get": 9, # TODO: fixme upstream (should be 8)
35753575
"list_dir": 2, # TODO: fixme upstream (should be 2)
35763576
"list_prefix": 0,
35773577
}
@@ -3593,8 +3593,8 @@ def test_append(self) -> None:
35933593

35943594
if has_zarr_v3:
35953595
expected = {
3596-
"set": 11, # TODO: fixme upstream (should be 4), see https://github.com/zarr-developers/zarr-python/issues/3199
3597-
"get": 23, # TODO: fixme upstream (should be 8), see https://github.com/zarr-developers/zarr-python/issues/3199
3596+
"set": 4,
3597+
"get": 9, # TODO: fixme upstream (should be 8)
35983598
"list_dir": 2, # TODO: fixme upstream (should be 2)
35993599
"list_prefix": 0,
36003600
}
@@ -3627,8 +3627,8 @@ def test_region_write(self) -> None:
36273627
with self.create_zarr_target() as store:
36283628
if has_zarr_v3:
36293629
expected = {
3630-
"set": 16,
3631-
"get": 8, # TODO: fixme upstream (should be 2), see https://github.com/zarr-developers/zarr-python/issues/3199
3630+
"set": 5,
3631+
"get": 2,
36323632
"list_dir": 2,
36333633
"list_prefix": 4,
36343634
}

0 commit comments

Comments
 (0)