Skip to content

Commit f6ded64

Browse files
authored
Pin inline-snapshot with an upper bound to fix wasm build (#1680)
1 parent 104d398 commit f6ded64

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

.github/workflows/ci.yml

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -362,8 +362,7 @@ jobs:
362362
# https://github.com/marketplace/actions/alls-green#why used for branch protection checks
363363
check:
364364
if: always()
365-
# TODO: add build-wasm-emscripten back when CI installation failures are solved:
366-
needs: [coverage, test-python, test-os, test-debug, lint, bench]
365+
needs: [coverage, test-python, test-os, test-debug, lint, bench, build-wasm-emscripten]
367366
runs-on: ubuntu-latest
368367
steps:
369368
- name: Decide whether the needed jobs succeeded or failed

tests/emscripten_runner.js

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -98,7 +98,8 @@ import importlib
9898
9999
await micropip.install([
100100
'dirty-equals',
101-
'inline-snapshot',
101+
# inline-snapshot 0.21 requires pytest 8.3.4, pyodide 0.26 ships with 8.1.1
102+
'inline-snapshot < 0.21',
102103
'hypothesis',
103104
'pytest-speed',
104105
'pytest-mock',

0 commit comments

Comments
 (0)